@Chris Are pre-releases expected to include submodules? I checked 1.0.0.rc0 and 1.0.0.rc1, neither of them contain source code of submodules.
On Tue, Jan 30, 2018 at 8:32 PM, Chris Olivier <cjolivie...@gmail.com> wrote: > All other relases have the submodule sources included > > On Tue, Jan 30, 2018 at 8:00 PM, sandeep krishnamurthy < > sandeep.krishn...@gmail.com> wrote: > > > I downloaded source from - > > https://github.com/apache/incubator-mxnet/archive/1.1.0.rc0.tar.gz and > > tried to build from source. > > Build failed as submodules (ps-list, mshadow) are empty directory in the > > source tar. > > > > Is this expected to not include submodules in source tar? > > > > > > On Tue, Jan 30, 2018 at 4:15 PM, Marco de Abreu < > > marco.g.ab...@googlemail.com> wrote: > > > > > +1 (binding) > > > > > > On Tue, Jan 30, 2018 at 3:20 PM, Indhu <indhubhara...@gmail.com> > wrote: > > > > > > > +1 (binding) > > > > > > > > > > > > On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <cjolivie...@gmail.com > > > > > > wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin < > > haibin.lin....@gmail.com > > > > > > > > > wrote: > > > > > > > > > > > Update: > > > > > > > > > > > > Link to release candidate 1.1.0.rc0: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1. > 0.rc0/ > > > > > > > > > > > > Link to the release tag: > > > > > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0 > > > > > > > > > > > > Best, > > > > > > Haibin > > > > > > > > > > > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin < > > > haibin.lin....@gmail.com > > > > > > > > > > > wrote: > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > Given that most people on dev@ are in favor of a minor release > > > > (1.1.0) > > > > > > > instead of a patch release due to API changes, I'd like to > > propose > > > a > > > > > vote > > > > > > > to release Apache MXNet (incubating) 1.1.0. Voting will start > now > > > > > > (Sunday, > > > > > > > January 28th) and end at 1pm Wednesday, January 31th PST. > > > > > > > > > > > > > > Link to release notes: > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/ > > > > > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes > > > > > > > > > > > > > > Link to release candidate 1.1.0.rc0: > > > > > > > https://github.com/apache/incubator-mxnet/releases/tag/ > 1.1.0.rc0 > > > > > > > > > > > > > > View this page and scroll down to “Build from Source” with > source > > > > code > > > > > > > obtained from the 1.1.0.rc0 tag: > > > > > > > https://mxnet.incubator.apache.org/install/index.html > > > > > > > > > > > > > > (Note: The README.md points to the 1.1.0 tag and does not work > at > > > the > > > > > > > moment.) > > > > > > > > > > > > > > Please remember to TEST first before voting accordingly: > > > > > > > +1 = approve > > > > > > > +0 = no opinion > > > > > > > -1 = disapprove (provide reason) > > > > > > > > > > > > > > Best, > > > > > > > Haibin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > Sandeep Krishnamurthy > > >
