Steffen, really thanks for the helps and I totally agree with you and Marco's suggestions. I will summarize the open issues and status for the review soon.
> What is your github handle? Github ID: Patric Zhao, https://github.com/pengzhao-intel/ Da Zheng, https://github.com/zheng-da/ > - do you have design docs we can link to? Does the doc cover packaging, use > of MXNet with full MKL (I understand there are license issues, but we do have > users who are or plan to use MXNet with the complete MKL package, not just > DNN subset)? Design doc: https://cwiki.apache.org/confluence/display/MXNET/The+design+of+MKLDNN+integration It's a good suggestion for the full MKL package and we will add the related part in the doc. > - do you have performance measurements (or plan to measure) to include in > release notes? Yes, we have tested the performance on all C4/C5 instances (8x,4x,2x,xlarge,large). And the accuracy are verified as well. We plan to publish these data both in the release note and mxnet website (https://mxnet.incubator.apache.org/faq/perf.html). > - should we talk about the package at the Apr 24th meetup in Seattle? We're based in Shanghai, China; so maybe @Da Zheng? > -----Original Message----- > From: Steffen Rochel [mailto:steffenroc...@gmail.com] > Sent: Sunday, March 11, 2018 6:11 PM > To: dev@mxnet.incubator.apache.org > Cc: marco.g.ab...@googlemail.com > Subject: Re: call for contributions to next MXNet release > > Patric - added MKL-DNN to the project list. What is your github handle? > I do agree with Marco that we need to resolve disable tests, broken features > etc. Jira looks like the right answer to create a list of known issues. > Questions I do have: > - do you have design docs we can link to? Does the doc cover packaging, use > of MXNet with full MKL (I understand there are license issues, but we do have > users who are or plan to use MXNet with the complete MKL package, not just > DNN subset)? > - do you have performance measurements (or plan to measure) to include in > release notes? > - should we talk about the package at the Apr 24th meetup in Seattle? > > Steffen > > On Sat, Mar 10, 2018 at 4:40 AM Zhao, Patric <patric.z...@intel.com> > wrote: > > > Hi Marco, > > > > Thanks for the inputs. > > > > MKL-DNN is just merged to the master branch in a month. I agree that > > it's not very mature. > > But, in my mind, there're NO major issues in the current implementation. > > > > The previous data race (flaky test) issue is fixed by Zheng Da. > > We have submitted the PRs to fix the building issues and setup Clang > > CI environment, such as in OSX and Cmake. > > Meanwhile, we are actively working on the MXNET for the performance, > > functionality and usability improvements. > > > > More positively, I think we should summarize the open issues, and we > > can focus on these issues you've mentioned. > > > > Thanks, > > > > --Patric > > > > > -----Original Message----- > > > From: Marco de Abreu [mailto:marco.g.ab...@googlemail.com] > > > Sent: Saturday, March 10, 2018 9:36 AM > > > To: dev@mxnet.incubator.apache.org > > > Subject: Re: call for contributions to next MXNet release > > > > > > Hello Patric, > > > > > > please be aware of the fact that there are still a lot of disabled > > tests, open > > > MKLDNN issues, broken features and flaky tests that have not been > > > addressed yet. We agreed on merging MKLDNN for the time being to > > > allow broad testing and that we will revisit the state a bit before > > > the next > > release. > > > At the moment, I'd not be in favour of having MKLDNN being part of it. > > > > > > Best regards, > > > Marco > > > > > > Zhao, Patric <patric.z...@intel.com> schrieb am Sa., 10. März 2018, > > 02:30: > > > > > > > Hi Steffen, > > > > > > > > We'd like the MKL-DNN backend can be included in the next release. > > > > > > > > We (Intel engineers) and Zheng-Da (AWS engineer) can work on it. > > > > > > > > Could you help add the item in the table? > > > > > > > > Thanks, > > > > > > > > --Patric > > > > > > > > > > > > > -----Original Message----- > > > > > From: Steffen Rochel [mailto:steffenroc...@gmail.com] > > > > > Sent: Friday, March 9, 2018 9:29 PM > > > > > To: dev@mxnet.incubator.apache.org > > > > > Subject: call for contributions to next MXNet release > > > > > > > > > > Hi - I would like to propose the next MXNet release. > > > > > Initial draft content is listed at MXNet wiki > > > > > <https://cwiki.apache.org/confluence/display/MXNET/Project+Propo > > > > > sals > > > > > +fo > > > > > r+next+MXNet+Release>. > > > > > I would like to call to all contributors to add features you are > > > > > working > > > > on and > > > > > would like to see included in the release. Suggested code freeze > > > > > is March 30th with target release by mid April. > > > > > > > > > > Anirudh Subramanian and Chris Olivier have volunteered to > > > > > co-manage the release. > > > > > > > > > > Mark your date: we are planing public meetup on Apr 24th in Seattle. > > > > > Details to follow. > > > > > > > > > > Regards, > > > > > Steffen > > > > > >
