What is there now should be fine.  MyFacesGenericPortlet belongs with
impl.  It is no different from MyFacesServlet in that regard.

The problem is that the JSF spec never got around to defining JSFPortlet
the way they did FacesServlet.  They defined the functionality, but not
name of the Portlet.  I'll try to see that this is addressed in JSF 2.0
if I am still on the EG next time around.

In the mean time, I think the solution is to use delegation instead of
inheritance.  I will change the MyFacesGenericPortlet to define plug
points.  Then tomahawk can contain the needed plugins without extending
MyFacesGenericPortlet.  Then there will be no dependency.

Come to think of it, that is probably a cleaner solution anyway.  I hate
inheritance.

Do you follow me Shinsuke?

Stan Silvert
JBoss, Inc.
[EMAIL PROTECTED]
callto://stansilvert

> -----Original Message-----
> From: Sean Schofield [mailto:[EMAIL PROTECTED]
> Sent: Thursday, August 18, 2005 5:39 PM
> To: MyFaces Development
> Subject: Re: build order for MyFaces Portlet
> 
> Tomahawk should work with either the RI or MyFaces.  So if there is a
> dependency in the portlet stuff on MyFaces impl that needs to be added
> to JIRA and then fixed.  I haven't been following the portlet stuff
> but if its possible to move something our of impl and into the "share"
> subproject, that might be a solution.
> 
> sean
> 
> > > It is OK for tomahawk to reference the base impl, but it is not OK
for
> > > impl to reference tomahawk.
> >
> > I just reread my post and realized that the above may not be
correct.
> > It might be that tomahawk can only reference the JSF API and not
impl.
> >
> > Hmm.  Now I think I see your dilemma.
> >
> > Can anyone give an authoritative answer about tomahawk?
> >
> > > Stan
> > >
> > > > Regards,
> > > >   shinsuke
> > > >
> > > > > Stan Silvert
> > > > > JBoss, Inc.
> > > > > [EMAIL PROTECTED]
> > > > > callto://stansilvert
> > > > >
> > > > >
> > > > >>-----Original Message-----
> > > > >>From: Shinsuke SUGAYA [mailto:[EMAIL PROTECTED]
> > > > >>Sent: Thursday, August 18, 2005 9:48 AM
> > > > >>To: Stan Silvert
> > > > >>Subject: build order for MyFaces Portlet
> > > > >>
> > > > >>Hi Stan,
> > > > >>
> > > > >>I'm working on MyFaces' portlet.
> > > > >>For build order, I encountered the issue.
> > > > >>I would like to use AddResource in impl/ directory, but
> > > > >>AddResource class is in tomahawk. Therefore, I could not
> > > > >>build impl jar... Do you have any idea? My suggestion is
> > > > >>to create a new directory(ex. portlet) and move files for
> > > > >>the portlet. So, myfaces-portlet.jar is created. What do
> > > > >>you think?
> > > > >>
> > > > >>Regards,
> > > > >> shinsuke
> > > > >>
> > > > >>__________________________________
> > > > >>Save the earth
> > > > >>http://pr.mail.yahoo.co.jp/ondanka/
> > > > >
> > > > >
> > > >
> > > > __________________________________
> > > > Save the earth
> > > > http://pr.mail.yahoo.co.jp/ondanka/
> >
> >

Reply via email to