>I set up the environment and provide you new RC JARs. > >Makes sense ?
Yes, please. Thanks. If anyone thinks we have missed something please say so. Dennis Byrne >> >> Maybe I am missing something here, but I don't see why we can't just >> >> change the core 1.1.4 branch to depend on a branch for shared that was >> >> created ( or could be created ) at the same time. >> >> >> >> >Also, as you mentioned, we need a unit test for this to see if >> >> >whatever we do fixes things. Care to write one? Or maybe you can at >> >> >least elaborate on the bug description in JIRA so someone else can >> >> >write one. I just know the revision that you think broke things. I >> >> >don't know what the problem is. >> >> >> >> A good test for this would be to simulate Mike's web.xml in the Shale >> >> Mock environment. However I don't see why this is necessary until a >> >> 1.1.5 release. Is there any reason why 1368 is even an issue for the >> >> 1.1.4 release ? As Sean pointed out, it didn't even enter the code base >> >> until after the branch. >> > >> >ok >> > >> >> >> >> >Sean >> >> > >> >> >On 7/31/06, Dennis Byrne <[EMAIL PROTECTED]> wrote: >> >> >> >OK I missed this one: >> >> >> >> >> >> Hi Sean - "missed this" how? >> >> >> >> >> >> myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/util/StateUtils.java >> >> >> > >> >> >> >If we revert this change do we think this will fix the problem? I can >> >> >> >certainly take care of that ... >> >> >> >> >> >> I am fairly sure reverting this will fix 1368, but I do not see how >> >> >> that should only affect anything other than trunk once the pom in the >> >> >> 1.1.4 branch is pointed to the correct shared version. >> >> >> >> >> >> >Sean >> >> >> > >> >> >> >On 7/31/06, Sean Schofield <[EMAIL PROTECTED]> wrote: >> >> >> >> Sorry. Missed the bit about the shared branch in the wiki. I >> >> >> >> thought >> >> >> >> Matthias had told me that he created it. >> >> >> >> >> >> >> >> Sean >> >> >> >> >> >> >> >> On 7/31/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: >> >> >> >> > On 7/31/06, Sean Schofield <[EMAIL PROTECTED]> wrote: >> >> >> >> > > I guess there was no branch made for the shared project at the >> >> >> >> > > same >> >> >> >> > > time that the core branched? If so we need to make a branch now >> >> >> >> > > (retroactively) and make sure it does not include the >> >> >> >> > > problematic >> >> >> >> > > code. Then change the dependency in the core pom. >> >> >> >> > >> >> >> >> > This page is intended to capture information about the release, >> >> >> >> > including what branches were made and when: >> >> >> >> > >> >> >> >> > http://wiki.apache.org/myfaces/CoreRelease114 >> >> >> >> > >> >> >> >> > As Matthias mentioned, he branched shared and core at the same >> >> >> >> > time. >> >> >> >> > But that was on June 21, and the commit mentioned on MYFACES-1368 >> >> >> >> > was >> >> >> >> > on July 4th. It can't be in the branch unless it was merged in. >> >> >> >> > >> >> >> >> > We also have a STATUS document which lists the trunks and active >> >> >> >> > branches: >> >> >> >> > >> >> >> >> > http://svn.apache.org/repos/asf/myfaces/current/STATUS.txt >> >> >> >> > >> >> >> >> > If anything is missing, please add it. >> >> >> >> > >> >> >> >> > -- >> >> >> >> > Wendy >> >> >> >> > >> >> >> >> >> >> >> > >> >> >> >> >> >> >> >> >> >> >> > >> >> >> >> >> >> >> > >> > >> >-- >> >Matthias Wessendorf >> > >> >further stuff: >> >blog: http://jroller.com/page/mwessendorf >> >mail: mwessendorf-at-gmail-dot-com >> > >> >> >> > > >-- >Matthias Wessendorf > >further stuff: >blog: http://jroller.com/page/mwessendorf >mail: mwessendorf-at-gmail-dot-com >
