On Wed, Oct 21, 2009 at 12:20 PM, Jan-Kees van Andel <[email protected]> wrote: > 2009/10/21 Matthias Wessendorf <[email protected]>: >> On Wed, Oct 21, 2009 at 9:36 AM, Jan-Kees van Andel >> <[email protected]> wrote: >>> I've added those "constants". Can't remember why I made them public. I >>> assume because they are used by the BeanValidator class. >>> >>> The reason to make them static final with the static initializer block >>> was because it made them easy to use and also because it's very >>> efficient (performance wise). >> >> well, we can't mess up with the dictated API (by the spec) > > Yeah. And with good reasons. The issue is just that this stuff is used > across packages (in this case validator and component). :-( > >>> Maybe they need to be refactored to some other class than UIInput? I >>> think so, especially since Bean Validation is not the only JSF2 >>> dependency. In the future we'll also have Web Beans and maybe JSR 330? >>> The amount of "is***Available" checks will definitely increase... >> >> we could have some package private stuff, which is fine. But we can't add >> other >> heavy dependencies to the API. As we have to pass - at some day - the TCK. > > Maybe we could add something like the _MessageUtils class we already > have. Something like _ExternalSpecifications, that gets redefined in > every package inside the API project.
+1 do you want to file a ticket on that > > Regards, > Jan-Kees > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
