Hi Volker, I already fixed 1111 issues in myfaces-core-api and about another 1000 in myfaces-core-impl (not only line-length). We had a lot lines which even exceeded the 160 chars, but I was really tired already and relaxed my own local checkstyle rules to 160 chars now.
But since you are a MyFaces Committer (even PMC) too, I'm perfectly fine with 120 if you could volunteer and fix another 600 checkstyle issues because of that - thanks a lot in advance! It's pretty easy. Just go to myfaces/core/impl and run $:> mvn checkstyle:check -Pcheckstyle you then get all the checkstyle errors in a file $:> less target/checkstyle-results.xml just search for 'error'. txs again and LieGrue, strub ----- Original Message ----- > From: Mark Struberg <[email protected]> > To: myfaces-dev <[email protected]> > Cc: > Sent: Friday, October 28, 2011 10:27 AM > Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160 > > Volker, source code is no newspaper. > > Imo 80 chars is definitely fine for C or perl with cryptic syntax (programmed > that myself for 20 years) but it's not nice for languages where descriptive > variable and method names are 'socially accepted' ;) > > > LieGrue, > strub > > > > ----- Original Message ----- >> From: Volker Weber <[email protected]> >> To: MyFaces Development <[email protected]>; Mark Struberg > <[email protected]> >> Cc: >> Sent: Friday, October 28, 2011 9:22 AM >> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160 >> >> Hi, >> >> -1. >> >> In my opinion 160 characters is much to wide, the current 120 is not >> the preferred, but the allowed max width. >> I vote for 80 characters as preferred max width. >> >> In general reading is easier if the text is not too wide, thats why >> newspaper articles are layouted in columns. >> >> >> Regards, >> Volker >> >> 2011/10/26 Mark Struberg <[email protected]>: >>> Hi! >>> >>> Currently we have really long and very descriptive variable names in >> MyFaces. >>> >>> I personally like that, but due to that we are really often exceeding > the >> 120 character per line. >>> >>> Thus my question: should we extend this from 120 to 160 characters > being >> allowed per line? >>> >>> [+1] yup make 160 the max default >>> [0] don't care >>> [-1] nope, let's stick with 120 >>> >>> open for 72h ... >>> >>> >>> Please make use of your vote, because I will activate the checkstyle > checks >> soon ;) >>> >>> here is my +1. >>> >>> LieGrue, >>> strub >>> >>> >> >> >> >> -- >> inexso - information exchange solutions GmbH >> Ofener Str. 30 | 26121 Oldenburg >> Tel.: +49 441 219 730 56 | >> FAX: +49 441 219 730 66 | eMail: [email protected] >> >> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251 >> Geschäftsführer: Stefan Schulte, Michael Terschüren >> >
