As I said earlier, the 160 char/line proposal was just made because I'm pretty tired of fixing the checkstyle issues in myfaces-core already.
If anyone is up for taking that piece of cake, then I'd be happy. Otherwise I will do it over the weekend. LieGrue, strub >________________________________ >From: Blake Sullivan <[email protected]> >To: MyFaces Development <[email protected]> >Cc: Gerhard Petracek <[email protected]> >Sent: Friday, October 28, 2011 8:13 PM >Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160 > > >I personally find 120 characters to be the best balance. On the bright side, >I expect that once we can use the diamond operator in JDK 7, the pressure for >longer lines will decrease. > >-- Blake Sullivan > >On 10/28/11 10:33 AM, Gerhard Petracek wrote: >@80: -1! >>@rest: +0 >> >>regards, >>gerhard >> >>http://www.irian.at >> >>Your JSF powerhouse - >>JSF Consulting, Development and >>Courses in English and German >> >>Professional Support for Apache MyFaces >> >> >> >> >>2011/10/28 Volker Weber <[email protected]> >> >>Hi Mark, >>> >>>2011/10/28 Mark Struberg <[email protected]>: >>> >>>> Volker, source code is no newspaper. >>> >>> just wanted to support the statement of easier reading in smaller >>>columns, of cause code is no newspaper, but it still need easy >>>reading. >>> >>>I don't like to scroll left and right to read the code, and even at >>>work were i got the widest screen the 1920px did not suffice to see >>>more than 120 characters with the project and structure sidebars left >>>and right, which i would not like to miss. >>> >>> >>>Regards, >>> Volker >>> >>> >>> >>>> >>>> Imo 80 chars is definitely fine for C or perl with cryptic syntax (programmed that myself for 20 years) but it's not nice for languages where descriptive variable and method names are 'socially accepted' ;) >>>> >>>> >>>> LieGrue, >>>> strub >>>> >>>> >>>> >>>> ----- Original Message ----- >>>>> From: Volker Weber <[email protected]> >>>>> To: MyFaces Development <[email protected]>; Mark Struberg >>>>> <[email protected]> >>>>> Cc: >>>>> Sent: Friday, October 28, 2011 9:22 AM >>>>> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160 >>>>> >>>>> Hi, >>>>> >>>>> -1. >>>>> >>>>> In my opinion 160 characters is much to wide, the current 120 is not >>>>> the preferred, but the allowed max width. >>>>> I vote for 80 characters as preferred max width. >>>>> >>>>> In general reading is easier if the text is not too wide, thats why >>>>> newspaper articles are layouted in columns. >>>>> >>>>> >>>>> Regards, >>>>> Volker >>>>> >>>>> 2011/10/26 Mark Struberg <[email protected]>: >>>>>> Hi! >>>>>> >>>>>> Currently we have really long and very descriptive variable names in >>>>> MyFaces. >>>>>> >>>>>> I personally like that, but due to that we are really often exceeding the >>>>> 120 character per line. >>>>>> >>>>>> Thus my question: should we extend this from 120 to 160 characters being >>>>> allowed per line? >>>>>> >>>>>> [+1] yup make 160 the max default >>>>>> [0] don't care >>>>>> [-1] nope, let's stick with 120 >>>>>> >>>>>> open for 72h ... >>>>>> >>>>>> >>>>>> Please make use of your vote, because I will activate the checkstyle checks >>>>> soon ;) >>>>>> >>>>>> here is my +1. >>>>>> >>>>>> LieGrue, >>>>>> strub >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> inexso - information exchange solutions GmbH >>>>> Ofener Str. 30 | 26121 Oldenburg >>>>> Tel.: +49 441 219 730 56 | >>>>> FAX: +49 441 219 730 66 | eMail: [email protected] >>>>> >>>>> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251 >>>>> Geschäftsführer: Stefan Schulte, Michael Terschüren >>>>> >>>> >>> >>> >>> >>>-- >>>inexso - information exchange solutions GmbH >>>Ofener Str. 30 | 26121 Oldenburg >>>Tel.: +49 441 219 730 56 | >>>FAX: +49 441 219 730 66 | eMail: [email protected] >>> >>>Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251 >>>Geschäftsführer: Stefan Schulte, Michael Terschüren >>> >> > > >
