[
https://issues.apache.org/jira/browse/MYFACES-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969360#comment-16969360
]
Bill Lucy commented on MYFACES-4309:
------------------------------------
Sorry, my comment wasn't very clear. With my patch, the buffer size increase
is no longer required in any of the cases I've looked at (including both CDI
and ManagedBeans.) But I understand the tradeoff with my patch is that there
will be some cases where a session will be created incorrectly.
The reason that I've raised this issue is that the change in 4297 causes a
large number of failures in the test suite we run. Many of those tests can be
fixed by increasing FACELETS_BUFFER_SIZE - it's just concerning to me that a
potentially high number of users will need to change their app config for
2.3.5.
Perhaps as an alternative to my current patch, we could update
getResponseEncoding to only create a session if the current view is not
transient or client side state saving is not enabled? Even a simpler change
like that would limit the need for increasing the buffer size in a lot of
existing apps.
> Session is broken in some cases due to MYFACES-4297
> ---------------------------------------------------
>
> Key: MYFACES-4309
> URL: https://issues.apache.org/jira/browse/MYFACES-4309
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.3.5
> Reporter: Bill Lucy
> Assignee: Bill Lucy
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The changes made for MYFACES-4297 introduced a problem: in some cases a
> session is not created early enough for a session cookie to be written out on
> a response before it is committed, due to the small default response buffer
> size. As mentioned in the comments for 4297, that behavior causes a problem
> for the ViewScope (and I expect the session as well.)
> As discussed, increasing the javax.faces.FACELETS_BUFFER_SIZE is a
> workaround, but that's not ideal for a few reasons:
> 1. apps using the default buffer size value will be broken by the new
> behavior when updating to 2.3.5
> 2. there doesn't appear to be a way to update the buffer size for JSPs
> We should consider revisiting the changes made in MYFACES-4297. Or, if
> nothing else, we might want to add some way to change the default buffer size
> on the JSP path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
