werpu commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1300789844

   > @werpu Thanks for working on this!
   > 
   > I tested it out, and it's improved. However, I still see some odd behavior.
   > 
   > * The CSS stylesheets are applied (i.e background color changes), but the 
JS scripts aren't executed nor do I see network requests for them?
   > * The other thing I noticed is that resources are applied to the HEAD more 
than once ( which I don't think is intended per the TCK)
   > 
   > <img alt="image" width="800" 
src="https://user-images.githubusercontent.com/5934310/199529954-bb786461-47a7-46c9-bf65-5b9fa3b862d5.png";>
   
   
   
   > I tested it out, and it's improved. However, I still see some odd behavior.
   > 
   > * The CSS stylesheets are applied (i.e background color changes), but the 
JS scripts aren't executed nor do I see network requests for them?
   > * The other thing I noticed is that resources are applied to the HEAD more 
than once ( which I don't think is intended per the TCK)
   
   Ok I will do another round of testing... no resources should not be applied 
more than once...
   I have to check that and scripts should be executed. I will add additional 
tests and check where the problem is, thanks for testing. I will use your 
example now for testing (I thought the fix was easy enough to cover it with my 
unit tests only.
   Well sloppyness bites back instantly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to