werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1301040923
> For the duplicates, I click the button twice which then add the script / link elements each time. I saw Mojarra had map to avoid this problem. Could we do the same? Yes definitely, another solution simply would be to check for elements with the same tags and src or hrefs. Given we use querySelectorall, the speed impact for doing this is neglectable. I will add a fix and improved unit tests for this issue tomorrow, and I will also test the final code against your testcase, to make it watertight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
