sanha commented on a change in pull request #15: [NEMO-52] Make
SchedulingPolicy Stackable
URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187831720
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/SchedulerRunner.java
##########
@@ -42,23 +45,26 @@
public final class SchedulerRunner {
private static final Logger LOG =
LoggerFactory.getLogger(SchedulerRunner.class.getName());
private final Map<String, JobStateManager> jobStateManagers;
- private final SchedulingPolicy schedulingPolicy;
private final PendingTaskGroupCollection pendingTaskGroupCollection;
private final ExecutorService schedulerThread;
private boolean initialJobScheduled;
private boolean isTerminated;
private final DelayedSignalingCondition
mustCheckSchedulingAvailabilityOrSchedulerTerminated
= new DelayedSignalingCondition();
+ private ExecutorRegistry executorRegistry;
+ private SchedulingPolicy schedulingPolicy;
@Inject
public SchedulerRunner(final SchedulingPolicy schedulingPolicy,
Review comment:
Let's make this private if possible. If it is not easy, please add @
VisibleForTest at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
