sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187831424
########## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/RoundRobinSchedulingPolicy.java ########## @@ -42,162 +39,27 @@ public final class RoundRobinSchedulingPolicy implements SchedulingPolicy { private static final Logger LOG = LoggerFactory.getLogger(RoundRobinSchedulingPolicy.class.getName()); - private final ExecutorRegistry executorRegistry; - - /** - * The pool of executors available for each container type. - */ - private final Map<String, List<String>> executorIdByContainerType; - - /** - * The index of the next executor to be assigned for each container type. - * This map allows the executor index computation of the RR scheduling. - */ - private final Map<String, Integer> nextExecutorIndexByContainerType; - @Inject - @VisibleForTesting - public RoundRobinSchedulingPolicy(final ExecutorRegistry executorRegistry) { - this.executorRegistry = executorRegistry; - this.executorIdByContainerType = new HashMap<>(); - this.nextExecutorIndexByContainerType = new HashMap<>(); - initializeContainerTypeIfAbsent(ExecutorPlacementProperty.NONE); // Need this to avoid potential null errors + public RoundRobinSchedulingPolicy() { Review comment: private ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services