sanha commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187832401
########## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/SourceLocationAwareSchedulingPolicy.java ########## @@ -42,130 +37,44 @@ public final class SourceLocationAwareSchedulingPolicy implements SchedulingPolicy { private static final Logger LOG = LoggerFactory.getLogger(SourceLocationAwareSchedulingPolicy.class); - private final ExecutorRegistry executorRegistry; - private final RoundRobinSchedulingPolicy roundRobinSchedulingPolicy; - - /** - * Injectable constructor for {@link SourceLocationAwareSchedulingPolicy}. - * @param executorRegistry provides catalog of available executors - * @param roundRobinSchedulingPolicy provides fallback for TaskGroups with no input source information - */ @Inject - private SourceLocationAwareSchedulingPolicy(final ExecutorRegistry executorRegistry, - final RoundRobinSchedulingPolicy roundRobinSchedulingPolicy) { - this.executorRegistry = executorRegistry; - this.roundRobinSchedulingPolicy = roundRobinSchedulingPolicy; + public SourceLocationAwareSchedulingPolicy() { Review comment: private ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services