jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the
operations on ExecutorRegistry atomic
URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r190453736
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJobScheduler.java
##########
@@ -164,8 +170,8 @@ public void onTaskStateChanged(final String executorId,
final String taskId,
default:
throw new UnknownExecutionStateException(new Exception("This
TaskState is unknown: " + newState));
}
- } else if (attemptIdx < currentTaskAttemptIndex) {
- // We can ignore this late arriving message.
+ } else if (taskAttemptIndex < currentTaskAttemptIndex) {
+ // Do not change state, as this notification is for a previous task
attempt.
Review comment:
Could you add an example case on when this can happen?
This means that a task notified its scheduling attempt which is 'previous'
one, thus gets ignored.
When such case can occur?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
