jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the
operations on ExecutorRegistry atomic
URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189788885
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java
##########
@@ -297,6 +305,8 @@ public synchronized void onTaskStateChanged(final String
taskId, final TaskState
throw new IllegalStateTransitionException(
new Throwable("The stage has not yet been submitted for
execution"));
}
+
+ taskIdToCurrentAttempt.put(taskId, taskIdToCurrentAttempt.get(taskId) +
1);
Review comment:
Why increment scheduling attempt after `Task` became `COMPLETE`?
Isn't it double-counted, considering that we inc it on `EXECUTING`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
