jeongyooneo commented on a change in pull request #30: [NEMO-63] On-demand
dynamic optimization metric aggregation
URL: https://github.com/apache/incubator-nemo/pull/30#discussion_r194657946
##########
File path:
common/src/main/java/edu/snu/nemo/common/ir/vertex/MetricCollectionBarrierVertex.java
##########
@@ -29,7 +29,9 @@
*/
public final class MetricCollectionBarrierVertex<T> extends IRVertex {
// Partition ID to Size data
- private final Map<String, List<T>> metricData;
+ private T metricData;
+ private final List<String> blockIds;
Review comment:
`blockIds` information is logically independent from `metricData`. Metric
data here is the stats collected to use in DataSkewRuntimePass. Block ids are
used to designate the edges subjected to optimization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
