jeongyooneo commented on a change in pull request #30: [NEMO-63] On-demand
dynamic optimization metric aggregation
URL: https://github.com/apache/incubator-nemo/pull/30#discussion_r195082501
##########
File path:
common/src/main/java/edu/snu/nemo/common/ir/vertex/MetricCollectionBarrierVertex.java
##########
@@ -71,21 +75,36 @@ public void setDAGSnapshot(final DAG<IRVertex, IREdge>
dag) {
/**
* Method for accumulating metrics in the vertex.
- * @param key metric key, e.g. ID of the partition.
- * @param values metric values, e.g. the block size information of the
partition data.
+ * @param metric map of hash value of the key of the block to the block size.
*/
- public void accumulateMetric(final String key, final List<T> values) {
- metricData.putIfAbsent(key, values);
+ public void updateMetricData(final Map<K, V> metric) {
Review comment:
It would be indeed if the value is set only once. But actually it is updated
in RuntimeMaster and then replace original metric in `updateMetricData`
whenever DataSizeMetricMsg arrives. I think it looks awkward since the updating
mechanism itself is not straightforward :)
How about leaving it as is, and refactor it in NEMO-96?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
