jeongyooneo commented on a change in pull request #30: [NEMO-63] On-demand
dynamic optimization metric aggregation
URL: https://github.com/apache/incubator-nemo/pull/30#discussion_r194662468
##########
File path:
common/src/main/java/edu/snu/nemo/common/ir/vertex/MetricCollectionBarrierVertex.java
##########
@@ -71,21 +74,28 @@ public void setDAGSnapshot(final DAG<IRVertex, IREdge>
dag) {
/**
* Method for accumulating metrics in the vertex.
- * @param key metric key, e.g. ID of the partition.
- * @param values metric values, e.g. the block size information of the
partition data.
+ * @param metric the block size information of the partition.
*/
- public void accumulateMetric(final String key, final List<T> values) {
- metricData.putIfAbsent(key, values);
+ public void updateMetricData(final T metric) {
+ metricData = metric;
Review comment:
In current design, we can only either conduct on-demand metric aggregation
in RuntimeMaster manually like this, or make MetricCollectionBarrierVertex
aggregate metric on-demand(in this case, adding partition sizes as message
arrives) by explicitly typecast metric value to `Long`. Either way is ad hoc.
I think I should resolve this issue in NEMO-96, by replacing
MetricCollectionBarrierVertex to AggregationBarrierVertex that accepts
user-defined aggregation function and does on-demand metric aggregation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
