johnyangk commented on a change in pull request #72: [Nemo-59] Skewed
data-aware executor allocation
URL: https://github.com/apache/incubator-nemo/pull/72#discussion_r200861399
##########
File path:
runtime/common/src/main/java/edu/snu/nemo/runtime/common/optimizer/pass/runtime/DataSkewRuntimePass.java
##########
@@ -138,11 +167,24 @@ public PhysicalPlan apply(final PhysicalPlan
originalPlan,
currentAccumulatedSize -=
aggregatedMetricData.getOrDefault(finishingHashValue, 0L);
}
- // assign appropriately
- keyRanges.add(i - 1, HashRange.of(startingHashValue,
finishingHashValue));
+ boolean isSkewedHash = containsSkewedHash(skewedHashes,
startingHashValue, finishingHashValue);
Review comment:
Do this in SkewnessAwareSchedulingConstraint#testSchedulability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
