johnyangk commented on a change in pull request #72: [Nemo-59] Skewed
data-aware executor allocation
URL: https://github.com/apache/incubator-nemo/pull/72#discussion_r200861276
##########
File path:
runtime/common/src/main/java/edu/snu/nemo/runtime/common/data/HashRange.java
##########
@@ -19,22 +19,23 @@
* Descriptor for hash range.
*/
public final class HashRange implements KeyRange<Integer> {
- private static final HashRange ALL = new HashRange(0, Integer.MAX_VALUE);
-
+ private static final HashRange ALL = new HashRange(0, Integer.MAX_VALUE,
false);
private final int rangeBeginInclusive;
private final int rangeEndExclusive;
+ private boolean isSkewed;
Review comment:
Can we do without introducing this boolean here?
- It may be better to keep description (these key ranges are being used),
and interpretation (these key ranges are skewed) separate
- This boolean must be updated every time the corresponding key range, or
the definition of skewed key ranges change
- All KeyRange implementations should maintain this variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
