johnyangk commented on a change in pull request #72: [Nemo-59] Skewed
data-aware executor allocation
URL: https://github.com/apache/incubator-nemo/pull/72#discussion_r200859940
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/ExecutorRegistry.java
##########
@@ -89,8 +90,10 @@ synchronized void terminate() {
@VisibleForTesting
synchronized Optional<ExecutorRepresenter> findExecutorForTask(final String
taskId) {
for (final ExecutorRepresenter executor : getRunningExecutors()) {
- if (executor.getRunningTasks().contains(taskId) ||
executor.getCompleteTasks().contains(taskId)) {
- return Optional.of(executor);
+ for (Task runningTask : executor.getRunningTasks()) {
Review comment:
final Task
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
