sanha commented on a change in pull request #76: [NEMO-151] Add OutputWriters
for additional tagged outputs
URL: https://github.com/apache/incubator-nemo/pull/76#discussion_r202512383
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/task/TaskExecutor.java
##########
@@ -222,11 +227,13 @@ private void processElementRecursively(final
VertexHarness vertexHarness, final
}
// Recursively process all of the additional output elements.
- vertexHarness.getAdditionalTagOutputChildren().keySet().forEach(tag -> {
- while (!outputCollector.isEmpty(tag)) {
- final Object element = outputCollector.remove(tag);
- handleAdditionalOutputElement(vertexHarness, element, tag); //
Recursion
- }
+
vertexHarness.getIRVertex().getPropertyValue(AdditionalTagOutputProperty.class).ifPresent(tagToVertex
-> {
+ tagToVertex.values().forEach(tag -> {
Review comment:
Why is the `values()` of `tagToVertex` called `tag`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
