sanha commented on a change in pull request #76: [NEMO-151] Add OutputWriters
for additional tagged outputs
URL: https://github.com/apache/incubator-nemo/pull/76#discussion_r202512438
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/task/TaskExecutor.java
##########
@@ -417,18 +446,40 @@ private boolean handleDataFetchers(final
List<DataFetcher> fetchers) {
.collect(Collectors.toList());
}
- private List<OutputWriter> getChildrenTaskWriters(final int taskIndex,
- final IRVertex irVertex,
- final List<StageEdge>
outEdgesToChildrenTasks,
- final DataTransferFactory
dataTransferFactory) {
+ private List<OutputWriter> getMainChildrenTaskWriters(final int taskIndex,
Review comment:
Please describe the difference of this method and
`getAdditionalChilderenTaskWriters` as method-level comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
