sanha commented on a change in pull request #76: [NEMO-151] Add OutputWriters
for additional tagged outputs
URL: https://github.com/apache/incubator-nemo/pull/76#discussion_r202515893
##########
File path:
examples/beam/src/test/java/edu/snu/nemo/examples/beam/PartitionWordsByLengthITCase.java
##########
@@ -65,8 +67,36 @@ public void tearDown() throws Exception {
@Test (timeout = TIMEOUT)
public void test() throws Exception {
JobLauncher.main(builder
- .addJobId(PartitionWordsByLength.class.getSimpleName())
-
.addOptimizationPolicy(DefaultPolicyParallelismFive.class.getCanonicalName())
- .build());
+ .addResourceJson(executorResourceFileName)
+ .addJobId(PartitionWordsByLengthITCase.class.getSimpleName())
+
.addOptimizationPolicy(DefaultPolicyParallelismFive.class.getCanonicalName())
+ .build());
+ }
+
+ @Test (timeout = TIMEOUT)
+ public void testSailfish() throws Exception {
Review comment:
It seems that there are too many IT cases for this example. In my opinion,
it would be enough to have two tests which test default policy and one
optimization policy (sailfish or pado).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
