On 6/14/19 8:54 AM, Neil C Smith wrote:
On Fri, 14 Jun 2019 at 16:39, Laszlo Kishalmi <laszlo.kisha...@gmail.com> wrote:
Am I right in thinking you linked directly to the build artefacts
rather than staging the testing releases?
Yes, for 11.0. Since we didn't have an announced beta/rc/vc releases it
seemed to be easier.
Thanks. Yes, have since found your testing release emails - for some
reason were difficult to find - think my filtering went funny because
they were also going to netcat.
Out of interest, did you PR all required changes into the release
branch or push directly to the repo? I'm inclined to the former as a
sanity check on whether I've picked up everything that needs doing
anyway.
I usually announce the release workflow usually around the time when I
cut the release branch. Basically for cherry-picks, as they were
reviewed for master once, I committed them directly to the release
branch unless it would result a non-trivial merge. In the later case I
asked for a PR from the author(s) specific to the release branch.
Thanks. Well, that should be easier as we're merging everything from
master now!
However, I was thinking more about how you handled commits you made
*only* on the release branch (release specific stuff like version
number, launcher settings, etc.). Of course, some of those may not be
required now - sooner we can get them all configurable as build
parameters the better!
Best wishes,
Neil
Well if it was a really trivial change (like date change 2018 -> 2019),
I committed them directly everything else is through PR-s specific to
the release branch.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
