I would have loved to help here, but I have a big deadline coming up... > Now I intend to merge my own PR-2700 even though I'm not sure that is proper > etiquette? Seeing as PR-2700 builds on the work done by Peter Hull, then that means there has already been "two pairs of eyes" on this code. So the code review part can probably be considered done.
And as you say, the actual testing of the compiled binaries would be the topic of the next PR in the series. So as long as the build tests still pass, it would seem good to get PR-2700 merged. Thanks again to Lars and Peter for your work on this! -- Eirik -----Original Message----- From: Lars Bruun-Hansen <[email protected]> Sent: Thursday, April 1, 2021 11:19 AM To: [email protected] Subject: Profiler crash on Windows (was: [NOTICE] Last PRs for Apache NetBeans 12.4 Beta) PR-2700 (making the Profiler work on Windows with JDK 9+) must not be forgotten, IMO. I've called for Linux and MacOS folks to test in a previous thread. No response. Now I intend to merge my own PR-2700 even though I'm not sure that is proper etiquette? In any case, merging PR-2700 will not make the bug fix into the IDE distribution. After merge of PR-2700 someone with permission will need to take the ZIP artifact it produces and upload the ZIP into https://netbeans.osuosl.org/binaries/. (naming the file "profiler-external-binaries-ASF.zip"). Then, yet another PR needs to be created which changes the Ant script as explained in PR-2700. This follow-up PR is where the real integration takes place and essentially this is where you should put your foot down if you believe the new native libs are not working. I'll be happy to do the follow-up PR as well. Can we do all that in 24 hours? Not sure, but let's try. This problem, that the Profiler crashes on Windows with JDK9+, has been going on too long. Please help me in moving it along. /Lars On Thu, Apr 1, 2021 at 11:45 AM Geertjan Wielenga <[email protected]> wrote: > > Hi all, > > Your brave release managers (the undersigned and Neil C. Smith), will > according to our schedule tomorrow put together a Beta release for > 12.4, including a vote thread once the sources and convenience > binaries are available. > > That means that, please: > > 1. This is a last call for PRs to be included in Beta. > > 2. Tomorrow we'll stop merging while release124 branch is created. > > 3. The current delivery branch will be deleted and a new one will be > created on feature freeze. > > Feel free to respond with any concerns or questions or any PRs that > are not merged yet that need to not be forgotten about. > > Thanks, > > Gj --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
