On 10/18/21 11:43 AM, Michael Bien wrote:
On 18.10.21 08:30, Jaroslav Tulach wrote:
On 17.10.21 18:17, Jaroslav Tulach wrote:

    >> This is a week later than in the schedule, primarily due to the
    delay
    >> in merging nb-javac with JDK 17 support.
    > Shalln't we integrate the nb-javac for real? E.g.:
    > https://github.com/apache/netbeans/pull/3251
    > -jt
    >
    this would make it available by default, but is it still possible to
    turn it off, e.g to test java 18 code?


That's a developer request, right? We don't want to scare regular NetBeans users with such confusing configuration, I assume. At least the biggest UX motivation for including nb-javac by default is to avoid all the download dialogs when one wants to use NetBeans to develop Java. It should work out of the box.

getting rid of the dialog is a worthy effort i suppose, but is it still possible to disable the nb-javac module in the plugin manage without breaking NB after the change?


I have to admit, i never installed nb-javac so far, for the simple reason that if i wanted to test early access JDKs (panama, loom, crac, you name it), all i had to do was to start NB with that JDK. NB then tried in a "best effort" manner to provide editor support using the ea javac - which usually worked good enough for testing or bugfixing purposes.

Opening a project which has a higher language level than nb-javac knows however would break everything.

I also never use old JDKs for any of my dev tools in general, unless it would break something. So the difference between javac and nb-javac is usually small anyway.


Yeah, would you not, please? I use Netbeans with built-from-source JDKs and have to remove nb-javac too. AFAIK there isn't anything broken that wasn't already(refactoring) without it.


Side note: using an older nb-javac isn't that bad from what I can remember. It's only when you use features that are no longer in preview or are newly introduced that Netbeans goes nuts. It isn't necessarily about language level, from what I've experienced.



-michael


    it would be also nice to have a build job building the automatically
    backported nb-javac from openjdk HEAD and put that somewhere.

Yes, that would be great. However please note that the
https://github.com/apache/netbeans/pull/3251
proposes to use the manually crafted [email protected] right now.

Of course, the ultimate goal of all these changes is to simplify our codebase by avoiding reflection needed to mitigate dealing with different versions of Javac from all the different JDKs. Automatically backported nb-javac should play an important role in such mission in the future.
-jt




---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to