On Sat, 9 Nov 2024 at 08:46, Michael Bien <mbie...@gmail.com> wrote: > multiple choice: > a) should we give up on commit author validation and remove this line? > https://github.com/apache/netbeans/blob/7d89336259b840ce53709cbc8240c88e32fd6ea1/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L13 > b) try validation during CI as proposed in the PR > c) do something else?
Option b) I think unless we decide, against previous decisions, that we don't care about accurate author information in the git history. Either we care about this or we don't! > reviewer guide: > may I add a note to the reviewer guide in the sense of: > "Committers shall avoid changing the PR target branch without leaving a > comment. Changing the target typically will also require a rebase, CI > run and renewed reviewer approval." Please do! We need to reduce the chance of situations like the recent accidental merges to delivery happening again in future. Change of branch to delivery *requires* reviews to be re-done - let's make that more explicit than "typically". Anyone changing the target branch should also make sure that any previous approvals are re-requested at the same time. We could possibly even enforce or automate some of this via GH Actions quite simply, assuming there's a trigger for base branch changes? Likewise, we could add here that following [NOTICE] emails on dev@ is a *requirement* for active committers. This is particularly important for anyone merging to any branch on the repository. We should perhaps remind all committers of this? Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
