On 09.11.24 10:41, Neil C Smith wrote:
On Sat, 9 Nov 2024 at 08:46, Michael Bien <mbie...@gmail.com> wrote:
multiple choice:
a) should we give up on commit author validation and remove this line?
https://github.com/apache/netbeans/blob/7d89336259b840ce53709cbc8240c88e32fd6ea1/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L13
b) try validation during CI as proposed in the PR
c) do something else?
Option b) I think unless we decide, against previous decisions, that
we don't care about accurate author information in the git history.
Either we care about this or we don't!
reviewer guide:
may I add a note to the reviewer guide in the sense of:
"Committers shall avoid changing the PR target branch without leaving a
comment. Changing the target typically will also require a rebase, CI
run and renewed reviewer approval."
Please do! We need to reduce the chance of situations like the recent
accidental merges to delivery happening again in future.
Change of branch to delivery *requires* reviews to be re-done - let's
make that more explicit than "typically". Anyone changing the target
branch should also make sure that any previous approvals are
re-requested at the same time.
I added this section to the "Pull requests for delivery" page:
- - -
Notes on retargeting existing PRs from master to delivery (or vice versa):
* Committers should not change the PR target branch without leaving a
comment. Changing the target will require to rebase the branch, a fresh
CI run and renewed reviewer approval.
* Please renew the review requests if the PR target is modified.
- - -
Feel free to change the wording if you like.
The commit header validator is now also merged and should be active for
fresh CI runs. If anyone is seeing any false positives or if it is
disrupting your workflow - please let me know.
We could possibly even enforce or
automate some of this via GH Actions quite simply, assuming there's a
trigger for base branch changes?
there might be a trigger for PR target changes. But our CI can't do a
lot with this information. Anything interesting would require write
permissions to the PR. (leave a comment to ping reviewers or something
like that).
I wouldn't want to mess with permissions unless it can't be avoided. We
probably also can't change them without talking to infra.
Likewise, we could add here that following [NOTICE] emails on dev@ is
a *requirement* for active committers. This is particularly important
for anyone merging to any branch on the repository. We should perhaps
remind all committers of this?
we could write a [NOTICE] mail ;)
best regards,
michael
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
