Hi, Am Montag, dem 04.11.2024 um 20:28 +0100 schrieb Michael Bien: > I would also like to update the reviewer guide with another note: > reviewers should not change the PR target without also leaving a comment > on the PR. We had at least one situation where the committer who merged > did likely not notice that the target changed! Further: retarget will > almost always also require rebaseing of the branch + new CI run after > rebase + new manual testing (review!) in case of delivery integration - > so this _can't_ be simply changed without communication.
this makes sense to me. > commit header validation during CI: > > I re-tested and updated yesterday an old PR which is an attempt to > implement basic commit header validation. We talked about this on > several occasions (usually after something happened, directly in the PR > comments or ASF slack), it will fail the "paperwork" job on > github-typical "noreply" mails, single-word author names (indicator for > github account name) and empty or single word commit messages (indicator > for unsquashed PR accidents about to happen). > > This is only there to prevent the most common accidents/mistakes, it > will not actually validate emails or anything like that. > > This is imperfect of course and will cause the paperwork job to fail > more often (which is fine), esp when the PR is still in development. > This is why the paperwork job will now no longer prevent CI workspace > cleanup from taking place on failure. > > https://github.com/apache/netbeans/pull/6630 I agree with the idea and validated, that it works in the confines, that it can. I already expressed, that I don't like the usage of experimental features, but that is a side discussion, that does not invalidate the usefullness of the change. >From my POV this is good to go. Thank you Matthias --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
