On Tue, Nov 21, 2017 at 10:12 AM, Bertrand Delacretaz < [email protected]> wrote:
> Hi, > > On Mon, Nov 13, 2017 at 11:01 PM, Geertjan Wielenga > <[email protected]> wrote: > > ...Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)... > > +1 on the release of this archive: > > SHA1(incubating-netbeans-platform-9.0-alpha-source.zip)= > 1189b293cecfd5236cf18df2c2bd0f6b414dab75 > which is found under > https://dist.apache.org/repos/dist/dev/incubator/netbeans/ > incubating-netbeans-platform/incubating-9.0-alpha/ > > Signature is ok using the key found in > https://dist.apache.org/repos/dist/dev/incubator/netbeans/KEYS > > Digests are ok > > LICENSE NOTICE DISCLAIMER look good to me. > > In my opinion, DEPENDENCIES does not provide enoughj information as to > why some GPL dependencies are considered compile time only. I > understand https://github.com/apache/incubator-netbeans/pull/278 will > improve that, so not a blocker for this release. > > The 9.0-alpha-rc2 Git tag has been added as well, that's good and > please add that to the netbeans release process documentation - a Git > tag is required to allow people to verify that the release matches a > specific state of the Git repository. > On this: original (Mercurial) binary builds used to include hg changeset id. I think we should restore that for git, and include the hash also in the source build. Technically, seems like a better solution (no manual intervention needed, the hash is imprinted in the release candidate, so no danger it will be removed, one does not need to guess tag name, etc.) If it is a rule that we need to tag all candidates, we can still do that, but to check the content of the repository and the release zip, a hash in the file seems like a better solution. Jan > The <patternset id="non.rat"> in nbbuild/build.xml defines a LOT of > rat exclusions, I think they are ok at this point but it would be good > to streamline that if possible and maybe move to a separate file for > clarity. > > I have not reviewed the convenience binaries, just the Apache source > release. > > -Bertrand >
