On Sat, Nov 18, 2017 at 12:59 AM, Ate Douma <[email protected]> wrote: > Here we go: +1 (binding) > > This release candidate looks pretty good to me, nice work everyone! >
Many thanks indeed! Created these two issues from your comments below: https://issues.apache.org/jira/browse/NETBEANS-157 https://issues.apache.org/jira/browse/NETBEANS-158 Will now put together the IPMC vote thread, and will list the issues discovered so far with links to their JIRA tickets as well. Thanks, Gj > > But of course, there's always something to nitpick about :-) > I checked the rat output and noticed one oddity: > nbi/infra/utils/comment-correcter/cddl.txt > > That looks like a default comment template file, which I assume also > can or should be changed to AL2? > Maybe something to fix for a next release? > > For the vote on the IPMC I suggest collecting and listing the issues > discovered so far, with a link to a JIRA ticket (if created) for fixing > them. So IPMC member are aware of what the PPMC already is aware of and > don't need to lose time and report the same issues again. > > And also please provide some minimal explanation of the purpose and > usage/usefulness of the binary distribution, including how to 'test' > (start) it, and mention that that doesn't yet work on Windows. > > Regards, > Ate > > > On 2017-11-17 11:00, Ate Douma wrote: > >> >> >> On 2017-11-17 10:44, Geertjan Wielenga wrote: >> >>> Excellent, thanks. >>> >>> It seems to me we have everything in place to go ahead with the IPMC >>> vote. >>> >>> It would be useful though if one or our mentors would check through >>> everything first, especially since this is the first time we're doing >>> this >>> for this part of Apache NetBeans. I'd feel more comfortable going to the >>> IPMC vote if we could start that vote with already having at least one >>> mentor supporting it via a +1. >>> >> >> I will be able to review the release candidate this evening, >> after office hours. >> And the same for the HTML/Java API vote already on IPMC. >> >> Sorry I couldn't free up time earlier this week. >> >> Ate >> >> >>> Gj >>> >>> >>> >>> On Fri, Nov 17, 2017 at 10:28 AM, Jan Lahoda <[email protected]> wrote: >>> >>> Hi, >>>> >>>> So I: >>>> -added a KEYS file with my key (I have it also registered on >>>> id.apache.org >>>> , >>>> but it will take time before it propagates): >>>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/KEYS >>>> -and added the release candidate files here: >>>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/ >>>> incubating-netbeans-platform/incubating-9.0-alpha/ >>>> (please also note the directory structure: >>>> incubating-netbeans-platform/incubating-9.0-alpha/) >>>> >>>> Could someone please check if I did it correctly? >>>> >>>> Thanks! >>>> >>>> Jan >>>> >>>> >>>> On Thu, Nov 16, 2017 at 8:51 PM, Geertjan Wielenga < >>>> [email protected]> wrote: >>>> >>>> On Wed, Nov 15, 2017 at 4:50 PM, Jan Lahoda <[email protected]> wrote: >>>>> >>>>> For the IPMC vote, I'd suppose it might be good to actually stage the >>>>>> release (signed and with hashes): >>>>>> http://www.apache.org/legal/release-policy.html#stage >>>>>> >>>>>> IMO if the only thing we need to change is the filename, it should be >>>>>> enough to rename before committing to the SVN (the file name will need >>>>>> >>>>> to >>>> >>>>> be changed in the hash file as well/the hash files will need to be >>>>>> regenerated, although the hash itself should remain the same). >>>>>> >>>>>> >>>>>> >>>>> OK, can you do this, Jan? >>>>> >>>>> Gj >>>>> >>>>> >>>>> >>>>> >>>>> Jan >>>>>> >>>>>> >>>>>> On Wed, Nov 15, 2017 at 4:33 PM, Geertjan Wielenga < >>>>>> [email protected]> wrote: >>>>>> >>>>>> That means we need to make a new artifact with that name and start a >>>>>>> >>>>>> new >>>>> >>>>>> vote thread here for that artifact? >>>>>>> >>>>>>> Or do we start a vote thread at the IPMC with the newly named >>>>>>> >>>>>> artifact? >>>> >>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Gj >>>>>>> >>>>>>> On Wed, Nov 15, 2017 at 2:59 PM, Bertrand Delacretaz < >>>>>>> [email protected] >>>>>>> >>>>>>>> wrote: >>>>>>>> >>>>>>> >>>>>>> On Wed, Nov 15, 2017 at 3:47 PM, Geertjan Wielenga >>>>>>>> <[email protected]> wrote: >>>>>>>> >>>>>>>>> ..."Shouldn't the name of the ZIP start with "incubating" ? >>>>>>>>> >>>>>>>> >>>>>>>> As per http://incubator.apache.org/guides/releasemanagement.html - >>>>>>>> "Release artifacts must include incubating in the final file name" >>>>>>>> >>>>>>>> -Bertrand >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>
