Hello Christian, I believe I might have been the 'reviewer' on your PR. If so, I apologise for making you feel unwelcome.
It would be nice if you would explain what your expectation in this case were. (There are some hints in your email, particularly the idea that there should be continuous feedback, a completion, etc.) >From my perspective, I was not "the" reviewer, I was just "a" reviewer. I >noticed your PR, thought about it a bit and gave my feedback. Clearly the >initial PR was too big and there were some problems with those dependencies. How cool that you also found a bug in JGit, right? Anyhow, don't take a PR personal or so serious. Some "reviewer" might be more interested in a given PR and follow it to the end. Other "reviewers" might just be passing through, notice some problems and point them out. I will certainly think more about a review creating a commitment, especially for first-time contributors. Obviously, there's always the option of sending an email on dev@. Usually GitHub shows me this notification when I get replies, I don't remember seeing anything new from that JGit PR... PS: Don't believe I'm undervaluing your time spent or your contributing. I have multiple contributions that went nowhere, so I totally know the feeling. I guess for some things you also need good timing... --emi ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On 21 April 2018 1:03 AM, Christian Bourque <[email protected]> wrote: > I have to agree with Gili... > > Sometimes it feels that nobody cares... I created a ticket a month ago > > about an improvement in the NetBeans Git integration and decided to code it > > myself. > > Then I submitted a PR and eventually the reviewing process started. But the > > reviewer has had many objections to my request (which is perfectly fine). I > > told him that the Eclipse JGit library was OSGi based and that it had > > external dependencies that were triggered during the bootstrapping of > > NetBeans. I even contacted the Eclipse team to tell them that one of their > > OSGi dependencies wasn't even used in their JGit library, the lead > > developer realized that it was a mistake and he fixed it! > > After that, I sent more questions and comments to the reviewer to > > understand how I could resolve the remaining issues in an acceptable way, > > but to no avail. The reviewer just stopped answering my questions! Now it's > > been 25 days and nothing... So, I put a lot of time into this for what at > > the end? > > I don't think that this is how you're going to attract new developers to > > contribute to this project... > > Christian > > On Fri, Apr 20, 2018 at 1:36 PM, cowwoc [email protected] wrote: > > > I did. Multiple times. > > > > One of the issues I brought up was the copy/paste bug I linked to below. > > > > When I brought it up in the mailing list in the past I got no replies. > > > > That issue (and its linked counterparts) are very annoying (for obvious > > > > reasons). I suspect no one else is experiencing this problem because it > > > > seems too major to ignore. > > > > Gili > > > > On 2018-04-20 1:21 PM, Geertjan Wielenga wrote: > > > > > Rather than filing hundreds of issues, I recommend you pick one, just one, > > > > > > and open a discussion thread around that. Once people have seen and > > > > > > discussed your issue on the mailing list, probably one of those will > > > > > > volunteer to tix it. > > > > > > Gj > > > > > > On Friday, April 20, 2018, cowwoc [email protected] wrote: > > > > > > This is precisely the kind of fixes I'm talking about. I understand that > > > > > > > IntelliJ has many features that Netbeans does not, but I'm primarily > > > > > > > > focused on improving the core development functionality (this is > > > > > > > > because > > > > > > > > it impacts all other project types). We've got many of the pieces in > > > > > > > > place, > > > > > > > > but UI problems make that functionality annoying/slow to use. > > > > > > > > Specifically > > > > > > > > on the point of 4k monitors, I keep on saying that it is impossible to > > > > > > > > copy/paste correctly: https://issues.apache.org/jira/browse/NETBEANS-235 > > > > > > > > (see linked issues as well) > > > > > > > > I have already filed thousands of issues before (literally), but those > > > > > > > > got > > > > > > > > flushed down the drain when we migrated to Apache. I've already filed > > > > > > > > some > > > > > > > > issues in Apache JIRA but for now there hasn't been much movement > > > > > > > > (committers are understandably working on their own issues before > > > > looking > > > > > > > > at other people's issues). Nothing personal against you guys but I don't > > > > > > > > have the time/energy to re-file all those bug reports. Family > > > > emergencies > > > > > > > > are keeping me super busy nowadays and frankly I don't see the point of > > > > > > > > doing all this work until I see some movement on the issues that I > > > > > > > > already > > > > > > > > filed. > > > > > > > > Gili > > > > > > > > On 2018-04-20 10:20 AM, John Leon wrote: > > > > > > > > I have been compiling a list myself of things I wanted to improve with > > > > > > > > > NetBeans as a relatively new user. I'll share them here, but I will > > > > > also > > > > > > > > > > keep an eye out for the Wiki page that Wade is going to make and try > > > > > to > > > > > > > > > > contribute there. Here are some of the examples I had in my list: > > > > > > > > > > - The Wizard dialog is always too small and I have to resize the > > > > > > > > > > > > > > > window > > > > > > > > > > to read everything. I want to make it remember the size of the last > > > > > > > > > > Wizard > > > > > > > > > > window. (This was going to be my first real plugin attempt) > > > > > > > > > > - The Project Groups menu item should have a sub-menu listing > > > > > > > > > > project > > > > > > > > > > groups in addition to the existing dialog window. This would allow > > > > > > > > > > someone > > > > > > > > > > to go File->Project Groups->My Project X directly, and only open > > > > > > > > > > the > > > > > > > > > > "project group manager" window if you need to add/modify groups. > > > > > > > > > > (Very > > > > > > > > > > minor convenience improvement) > > > > > > > > > > - Better 4k monitor support (right now requires fiddling with > > > > > > > > > > dpiaware > > > > > > > > > > and font size, sometimes images are scaled and pixelated still) > > > > > > > > > > - Can't run Windows command prompt in the Terminal > > > > > > > > > > - Add more padding/borders to the Darcula L&F as it feels crowded > > > > > > > > > > to > > > > > > > > > > me > > > > > > > > > > - With some L&F Some status bar/tooltips > > > > > > > > > > - Right click a file/folder -> Open in Explorer (Think this is a > > > > > > > > > > optional 3rd party plugin only currently) > > > > > > > > > > On Fri, Apr 20, 2018 at 7:49 AM, Christian Lenz > > > > > <[email protected] > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > Some other People say that, better indexing with NB over IntelliJ but > > > > > I > > > > > > > > > > > can say sometimes yes and sometimes not. I can say what I tested was > > > > > > > > > > > > the > > > > > > > > > > > > go > > > > > > > > > > > > to file and this is often clunky in NetBeans or the quick search is > > > > > > not > > > > > > > > > > > > that fast over intelliJ and and and. Open Options Needs some MS to > > > > > > open > > > > > > > > > > > > etc. So I can say that the Performance of IntelliJ is way better in > > > > > > > > > > > > different cases than in NetBeans. I will add some comparisions too. > > > > > > > > > > > > So NetBeans is my full enviroment for almost everything what > > > > > > NetBeans > > > > > > > > > > > > can > > > > > > > > > > > > handle for hopefully for more in the future and yes I can feel the > > > > > > > > > > > > indexing > > > > > > > > > > > > Problem too, what Wade mentioned. For Code completion, for go to > > > > > > > > > > > > whatever, > > > > > > > > > > > > searching etc. > > > > > > > > > > > > Cheers > > > > > > > > > > > > Chris > > > > > > > > > > > > Von: Geertjan Wielenga > > > > > > > > > > > > Gesendet: Freitag, 20. April 2018 13:56 > > > > > > > > > > > > An: [email protected] > > > > > > > > > > > > Betreff: Re: IntelliJ IDEA vs Netbeans > > > > > > > > > > > > Deklunkification on indexing and performance levels can be done with > > > > > > > > > > > > the > > > > > > > > > > > > code currently in Apache NetBeans Git. Jaroslav Tulach will have > > > > > > > > > > > > insights > > > > > > > > > > > > as well as gratitude for help in this area, while note that indexing > > > > > > > > > > > > and > > > > > > > > > > > > performance have subjective aspects, e.g., even in this thread > > > > > > there’s > > > > > > > > > > > > a > > > > > > > > > > > > preference expressed of NetBeans over IntelliJ in relation to > > > > > > > > > > > > performance. > > > > > > > > > > > > Gj > > > > > > > > > > > > On Friday, April 20, 2018, Wade Chandler [email protected] > > > > > > > > > > > > wrote: > > > > > > > > > > > > On Fri, Apr 20, 2018, 04:49 Geertjan Wielenga < > > > > > > > > > > > > > [email protected]> wrote: > > > > > > > > > > > > > > Deklunkifyng NetBeans was never a big goal in Oracle though now, > > > > > > > in > > > > > > > > > > > > > > Apache, > > > > > > > > > > > > > > this really seems a doable target and one we can work on together. > > > > > > > > > > > > > > > Many > > > > > > > > > > > > > > > > deklunkification tasks are probably quite trivial. How best to > > > > > > > > tackle > > > > > > > > > > > > > > > > this > > > > > > > > > > > > > > and who will take the lead in beginning to list these? Any > > > > > > > deklunking > > > > > > > > > > > > > > > I > > > > > > > > > > > > > > > > am > > > > > > > > > > > > > > able to implement I will implement, just provide a very specific > > > > > > > list > > > > > > > > > > > > > > > and > > > > > > > > > > > > > > > > we’ll form a NetBeans deklunking taskforce. > > > > > > > > > > > > > > > +1 this has been my goal with the move to Apache, and once we > > > > > > > > get > > > > > > > > > > > > > > > > more > > > > > > > > > > > > > > of > > > > > > > > > > > > > > the other bits over plan to try to tackle much of it. I love > > > > > > > > > > > > > > "Deklunkification Taskforce"! > > > > > > > > > > > > > > My biggest item I plan to look at is the indexing which blocks > > > > > > > some > > > > > > > > > > > > > > things, > > > > > > > > > > > > and impacts performance. It is really as far as I can tell the main > > > > > > > > > > > > > performance difference as it has impacts on the editor and other > > > > > > > UI > > > > > > > > > > > > > > actions. > > > > > > > > > > > > > > I much more prefer the integration of NB with the tools project > > > > > > > > > > > > > > support > > > > > > > > > > > > > > versus rolling our own. The classpath and build differences can > > > > > > > really > > > > > > > > > > > > > > be a > > > > > > > > > > > > bear sometimes when having differences between the two, and builds > > > > > > or > > > > > > > > > > > > > executions work in one side, but not the other. > > > > > > > > > > > > > > So, I find this a strength of NB, as I have helped team members > > > > > > > over > > > > > > > > > > > > > > the > > > > > > > > > > > > > > years with such issues in other environments. > > > > > > > > > > > > > > I will create a page in the Wiki later if nobody else has; right > > > > > > > now I > > > > > > > > > > > > > > must > > > > > > > > > > > > get ready for CodeStock! > > > > > > > > > > > > > Wade > > > > > > > > To unsubscribe, e-mail: [email protected] > > > > > > > > For additional commands, e-mail: [email protected] > > > > > > > > For further information about the NetBeans mailing lists, visit: > > > > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > For further information about the NetBeans mailing lists, visit: > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
