GitHub user steveyh25 opened a pull request:

    https://github.com/apache/nifi/pull/305

    NIFI-1686 - NiFi is unable to populate over 1/4 of AMQP properties from 
flow properties

    I've changed propertyNames into an enum so that we can refer to their 
values multiple times properly instead of hard-coding string values all over 
the place. The enum includes a lookup map that is built by a static block so we 
can get the enum "by value" efficiently.
    
    I've removed the reflective calls and so am using a setter for each 
property type - along with fixes for the 4 properties that had issues in the 
bug. Multiple headers can be passed in as follows: 
amqp$headers=foo$bar$foo2$bar2$foo3$bar3 etc. and the code will build the Map 
parameter that the Builder requires.
    
    Removed the now unnecessary variable amqpPropertyNames, and getter 
getAmqpPropertyNames.
    
    Fixed some spelling mistakes, amended doc comments, removed unused imports, 
made the test more robust by testing all of the properties instead of just 
contentType.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/steveyh25/nifi NIFI-1686

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/305.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #305
    
----
commit c686a11cbfb2256bbd645dc78902c730f46d8628
Author: Stephen Harper <[email protected]>
Date:   2016-03-26T20:06:50Z

    NIFI-1686 - NiFi is unable to populate over 1/4 of AMQP properties from 
flow properties

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to