Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/305#discussion_r57530669
--- Diff:
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java
---
@@ -43,16 +41,48 @@
private final static Logger logger =
LoggerFactory.getLogger(AMQPUtils.class);
- private final static List<String> propertyNames =
Arrays.asList("amqp$contentType", "amqp$contentEncoding",
- "amqp$headers", "amqp$deliveryMode", "amqp$priority",
"amqp$correlationId", "amqp$replyTo",
- "amqp$expiration", "amqp$messageId", "amqp$timestamp",
"amqp$type", "amqp$userId", "amqp$appId",
- "amqp$clusterId");
- /**
- * Returns a {@link List} of AMQP property names defined in
- * {@link BasicProperties}
- */
- public static List<String> getAmqpPropertyNames() {
- return propertyNames;
+ public enum PropertyNames {
--- End diff --
+1 here, primarily due to the fact that now individual properties
(especially non-Sttring-value type) may need additional logic to help with
conversion and therefore would need to be individually referenced in several
places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
