Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/305#issuecomment-202095259
@steveyh25
Thank you so much for your contribution. AMQP support is one of the most
recent additions to NiFi and it's great to see its adoption is on the way.
What's even more admirable is to see the
members (such as yourself) of the community are eager to help making it
even better by addressing some of the limitations these new components may have.
That said, keep in mind that certain limitations (especially in new
components) may be there intentionally (as in this case). In other words this
initial version of AMQP was not supporting _non-String-value-type_ properties
since we wanted to give more thoughts as to the conversion strategies of such
values to/from String given that NiFi attributes only support String as a value
type. I'll comment more on this inline at the relevant parts of the code, but
wanted to make sure that it is clear that such behavior was intentional and not
a bug. I'll update JIRA classification accordingly as well.
Also, instead of saying "1/4" consider listing _timestamp, deliveryMode,
headers, priority_ individually. The main point here is that one only cares
about properties he/she needs and if the other 3/4 satisfy those needs then all
is good while it may not be all good for others who need one of the unsupported
properties. So the emphasis here should be on specific property rather then
1/4.
Last but not least, consider the tone and basic ethics next time you
interact in a public forum (JIRA/Github etc.). When writing things like "the
author of the code mustn't have. . ." keep in mind that
you can not possibly know _what_, _where_ and _how_ in relation to the
"author's" _intent_, _thoughts_ and/or _motivation_ unless you had direct
interaction with him/her which I'll assume you didn't. Without such interaction
these words become pure speculation which personalizes the issue and therefore
counter productive. See more here:
http://www.apache.org/foundation/policies/conduct.html
That said, please see the comments in line as I go through the review.
Once again thank you for you contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
