Change that to +1 (non-binding) With longer timeouts the TestListenSMTP tests are now passing.
On Sun, Aug 28, 2016 at 10:04 PM, Joe Skora <[email protected]> wrote: > -1 (non-binding) > > It looks good in general, but Windows 10 unit tests consistently fail in > TestListenSMTP. > > It builds fine on OS X and Ubuntu has one error described below. > > It runs fine on OS X and Ubuntu including AWS S3 and HandleHTTP processors. > > 1. signature verifies > 2. hashes verify > 3. build and passes RAT check > a. OS X - builds and runs ok > b. Ubuntu 15.10 - builds with one error but runs ok [1] > c. Windows 10 - *FAILS* unit tests: > - Failing tests are > TestListSMTP.validateSuccessfulInteraction > TestListSMTP.validateSuccessfulInteractionWithTls > TestListSMTP.validateTooLargeMessage > - I tried Git core.autocrlf set to "input" and "false", in case it > was an EOL issue, but that made no difference. > 4. LICENSE, NOTICE, and README.MD look good > 5. RC commit ID is good > 6. RC is branched off correct commit ID > 7. binary runs as expected with a test flow include AWS *S3 and > HandleHTTP* processors > (including FetchFile, FetchS3Object, GenerateFlowFile, GetFile, > HandleHttpRequest, HandleHttpResponse, InvokeHttp, ListS3, > LogAttribute, PutFile, RouteOnAttribute, TransformXML, and > UpdateAttribute processors) > > > [1] The build fails on Ubuntu 15.10 like it did with 1.0.0-BETA, I have to > build with "--fail-never" to get a binary. The failing test is > TestPutUDP.testInvalidIPAddress(), > it could be a JVM bug or network issue on the box, but the system shows no > other problems. Tracking through the call stack, the native method > Inet6AddressImpl.lookupAllHostAddr() throws UnknownHostException on other > systems with stacktraces similar to the one below, but on this one there is > no exception thrown using Java 8 and Java 7 only throws the exception if > the "-Djava.net.preferIPv4Stack=true" property is defined. Since the > Mock framework doesn't actually transfer these files to the bad IP the test > expects the files to route to "failure" because fo the exception but > without the exception they go to "success"and the test fails. > java.net.UnknownHostException: 300.300.300.300: unknown error > at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method) > at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928) > at java.net.InetAddress.getAddressesFromNameService( > InetAddress.java:1323) > at java.net.InetAddress.getAllByName0(InetAddress.java:1276) > at java.net.InetAddress.getAllByName(InetAddress.java:1192) > at java.net.InetAddress.getAllByName(InetAddress.java:1126) > at java.net.InetAddress.getByName(InetAddress.java:1076) > at TestBadIpAddress.main(TestBadIpAddress.java:13) > > On Sun, Aug 28, 2016 at 9:25 PM, Bryan Rosander <[email protected]> > wrote: > >> Downloaded source >> >> Verified checksums >> >> Ran build with contrib-check and empty local repo >> >> Ran build with –T2 concurrency and empty local repo >> >> Used tls-toolkit to generate 4 localhost keystore, truststore, >> nifi.properties and a single client certificate >> >> Started all 4 instances verified no port conflicts, correct certificate >> usage >> >> Imported CA certificate, client cert into browser, verified tls working >> properly >> >> +1 (non-binding) >> >> Thanks, >> Bryan >> >> On Aug 28, 2016 7:30 PM, "Tony Kurc" <[email protected]> wrote: >> >> > +1 (binding) >> > >> > Full build starting with empty maven repository on Ubuntu 14.04 (x86_64) >> > successfully. >> > >> > Verified signatures and hashes. Reviewed LICENSE/NOTICE. >> > >> > Ran a simple flow with no issues. Ran a few nifi-toolkit commands. >> > >> > >> > >> > On Sun, Aug 28, 2016 at 5:29 PM, Joe Witt <[email protected]> wrote: >> > >> > > +1 (binding) >> > > >> > > Full clean build w/contrib check good. >> > > >> > > Verified signatures (and strength), hashes, and LICENSE/NOTICE within >> > > sources and convenience binaries. >> > > >> > > Verified the commit the release was based on. >> > > >> > > Ran single and multi-node clusters with favorable results. >> > > >> > > For future release please do move any necessary elements of the UnRar >> > > item to NOTICE where category B items belong. See here for LEGAL >> > > discuss https://issues.apache.org/jira/browse/LEGAL-52 on this. >> > > >> > > Great job pulling the release together again JoeP. >> > > >> > > Thanks >> > > Joe >> > > >> > > On Fri, Aug 26, 2016 at 12:25 PM, Joe Percivall >> > > <[email protected]> wrote: >> > > > Hello Apache NiFi Community, >> > > > >> > > > I am pleased to be calling this vote for the source release of >> Apache >> > > NiFi, >> > > > nifi-1.0.0. >> > > > >> > > > The source zip, including signatures, digests, etc. can be found at: >> > > > https://repository.apache.org/content/repositories/orgapache >> nifi-1090/ >> > > > >> > > > Note: There is a second binary being distributed now, the NiFi >> Toolkit. >> > > It >> > > > can be used to facilitate securing a NiFi instance. >> > > > >> > > > The Git tag is nifi-1.0.0-RC1 >> > > > The Git commit hash is 74d5224783dfdc513f6b3ad5ed96671d3c581707 >> > > > * https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h= >> > > 74d5224783dfdc513f6b3ad5ed96671d3c581707 >> > > > * https://github.com/apache/nifi/commit/74d5224783dfdc513f6b3a >> d5ed9667 >> > > 1d3c581707 >> > > > >> > > > Checksums of nifi-1.0.0-source-release.zip: >> > > > MD5: 8bdba49a73b94d036fad6c63b0ebe39d >> > > > SHA1: 504c58f9b2fb305c41598a17f5b78f68f2b2fa3d >> > > > SHA256: 22167ede5127683ca8de6dbd2fb911 >> 2cb1de650b7cfff7e640c905521447 >> > af92 >> > > > >> > > > Release artifacts are signed with the following key: >> > > > https://people.apache.org/keys/committer/jpercivall >> > > > >> > > > KEYS file available here: >> > > > https://dist.apache.org/repos/dist/release/nifi/KEYS >> > > > >> > > > 595 issues were closed/resolved for this release: >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> > > projectId=12316020&version=12332640 >> > > > >> > > > Release note highlights can be found here: >> > > > https://cwiki.apache.org/confluence/display/NIFI/ >> > > Release+Notes#ReleaseNotes-Version1.0.0 >> > > > >> > > > The vote will be open for 72 hours. >> > > > Please download the release candidate and evaluate the necessary >> items >> > > > including checking hashes, signatures, build from source, and test. >> > Then >> > > > please vote: >> > > > >> > > > [ ] +1 Release this package as nifi-1.0.0 >> > > > [ ] +0 no opinion >> > > > [ ] -1 Do not release this package because... >> > > > >> > > > Thanks! >> > > >> > >> > >
