It is undefined at this point and I agree we should reach consensus and document it.
I am in favor making non-committer reviews binding. Why do we do RTC: - To help bring along new committers/grow the community - To help promote quality by having peer reviews Enabling non-committer reviews to be binding still allows both of those to be true. On Thu, Jul 6, 2017 at 10:10 PM, Tony Kurc <trk...@gmail.com> wrote: > All, I was having a discussion with Mike Hogue - a recent contributor - off > list, and he had some questions about the review process. And largely the > root of the question was, if a non-committer reviews a patch or PR (which > Mike has spent some time doing), is that considered a "review"? I didn't > have the answers, so I went on a hunt for documentation. I started with the > Contributor Guide [1]. The guide describes reviewing, and calls out a > Reviewer role, but doesn't specifically point out that Reviewer is a > committer, just that a committer "can actively promote contributions into > the repository", and goes on to imply the non-committers can review. > > Given this, I was unable to answer this question: > If a committer "X" submits a patch or PR, it is reviewed by a non-committer > "Y", does that review satisfy the RTC requirement, and "X" may merge in the > patch? > > I found a related discussion on the email list in March [2], which I think > implies at least some of the community assumed the canonical review must be > by a committer. I also went back a bit to early days [3], where Benson > implied a much less "formal" review process. > > What I'm hoping for is hopefully come to a consensus of what our project > expectations are and document in the Contributor Guide. My expectation was > that non-committers could review, similar to what Sean discussed on this > thread for Apache Gossip (incubating) [4]. However, I don't believe this is > the current consensus. > > Thoughts? > > Tony > > 1. > https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeReviewProcess > 2. > https://mail-archives.apache.org/mod_mbox/nifi-dev/201703.mbox/%3CCALJK9a7onOKo%3DXtAEmL7PSBUEBEqOOhcT9WSz-RZaNxqV6q%3Dmg%40mail.gmail.com%3E > 3. > https://mail-archives.apache.org/mod_mbox/nifi-dev/201501.mbox/%3CCALhtWkf67UpOe9W9HQ3RSn00xb_=c6zmxn+_sefwthpqru5...@mail.gmail.com%3E > 4. > http://mail-archives.apache.org/mod_mbox/incubator-gossip-dev/201606.mbox/%3CCAN5cbe6P8aEEOLMA%2BPrfpQg9c_AWeSfvvmom8jAp%3Dk7wUpoVgQ%40mail.gmail.com%3E
