Joey I personally dont care all that much about the number of commits in PR - I think that rule is sort of soft already.
I dont think there is any inherent value in having a single module per JIRA (and PR or PR commit) on this. These can be done in much coarser grained chunks. It will have to be to get review cycles for instance (much less having the Github infra to run these builds). Thanks Joe On Wed, Aug 25, 2021 at 9:44 AM Joey Frazee <[email protected]> wrote: > > Maybe this is an exception to the single squashed commit guidance for the > initial pull? > > I assume the intent is to make incremental progress and not have a PR with a > hundred files affected, but if the different module changes corresponded to a > different commit, GH will make it easy enough to have a draft and review each > commit in isolation. > > Would that be a reasonable approach? > > -joey > > > On Aug 25, 2021, at 9:36 AM, Joe Witt <[email protected]> wrote: > > > > Mike, > > > > Seeing a pretty stunning flood of JIRAs for 'Refactor nifi-bla to use > > JUnit 5' and I'm guessing we'll see the same in terms of PRs. This is > > a really high administrative overhead approach to this. > > > > Why not break this into one or maybe a few JIRAs/PRs total? > > > > Thanks
