If possible I would like to see the fix in PR#9485 <https://github.com/apache/nifi/pull/9485> for NIFI-19963 <https://issues.apache.org/jira/browse/NIFI-13963> included as it is a fix my team needs. Thanks!
On Mon, Nov 11, 2024 at 7:10 AM Ferenc Kis <briansolo1...@apache.org> wrote: > Hi Team, > > I'm going to start the release process for NiFi 1.28.1 > > Just opened a PR for bumping dependencies to the latest versions: > https://github.com/apache/nifi/pull/9508 > Please help with the review and the merge so I can proceed with the > release. > > Thanks > Ferenc > > On Wed, Nov 6, 2024 at 1:33 PM Ferenc Kis <briansolo1...@apache.org> > wrote: > > > > Hi Joe, > > > > I'm happy to take the RM responsibilities for 1.28.1. > > > > Will start the release process within the next few days. > > > > Thanks > > Ferenc > > > > On Tue, Nov 5, 2024 at 6:11 PM Joe Witt <joe.w...@gmail.com> wrote: > > > > > > Ferenc, > > > > > > Thanks for the RM work on the 1.28 release. > > > > > > Are you up for doing a 1.28.1 release in the coming days? > > > > > > There are a few bugs fixed worth grabbing then a security relevant > update > > > both in the form of a DISCLAIMER file that will help communicate to > users > > > about the go forward nature of the 1.x line. > > > > > > Thanks > > > > > > On Fri, Oct 18, 2024 at 4:06 AM Ferenc Kis <briansolo1...@gmail.com> > wrote: > > > > > > > Great, thanks Matt > > > > > > > > On Fri, Oct 18, 2024 at 12:00 AM Matt Burgess <mattyb...@apache.org> > > > > wrote: > > > > > > > > > +1 I was informed that fix was backported already under a separate > Jira > > > > and > > > > > PR, so I'm good with going forward. > > > > > > > > > > On Thu, Oct 17, 2024 at 9:47 AM Matt Burgess <mattyb...@apache.org > > > > > > wrote: > > > > > > > > > > > As with 2.0.0, if we can backport [1] into 1.28 I think we > should. > > > > > > > > > > > > Thanks Ferenc! > > > > > > > > > > > > [1] https://github.com/apache/nifi/pull/9273 > > > > > > > > > > > > On Thu, Oct 17, 2024 at 8:11 AM Ferenc Kis < > briansolo1...@gmail.com> > > > > > > wrote: > > > > > > > > > > > >> Hi Team, > > > > > >> > > > > > >> all of the remaining tickets are now merged, so we can proceed > with > > > > the > > > > > >> release. > > > > > >> https://issues.apache.org/jira/projects/NIFI/versions/12354883 > > > > > >> > > > > > >> Please let me know if there are still any tickets in progress > which > > > > > could > > > > > >> be blockers for this release. > > > > > >> > > > > > >> I plan to start the release candidate process before the end of > this > > > > > >> week, if there are no objections. > > > > > >> > > > > > >> Regards > > > > > >> Ferenc > > > > > >> > > > > > >> On Thu, Oct 10, 2024 at 10:47 PM David Handermann < > > > > > >> exceptionfact...@apache.org> wrote: > > > > > >> > > > > > >> > Ferenc, > > > > > >> > > > > > > >> > Thanks for the reply! I will continue reviewing that soon to > get > > > > > >> > things ready for the release. > > > > > >> > > > > > > >> > Regards, > > > > > >> > David Handermann > > > > > >> > > > > > > >> > On Thu, Oct 10, 2024 at 1:51 PM Ferenc Kis < > briansolo1...@gmail.com > > > > > > > > > > >> > wrote: > > > > > >> > > > > > > > >> > > Thanks David! > > > > > >> > > > > > > > >> > > We are still waiting for > > > > > >> > https://issues.apache.org/jira/browse/NIFI-13744, > > > > > >> > > it seems to be important to get into 1.28 > > > > > >> > > Once it is merged and backported to 1.28, I plan to start to > > > > release > > > > > >> > process > > > > > >> > > > > > > > >> > > Regards > > > > > >> > > Ferenc > > > > > >> > > > > > > > >> > > On Thu, Oct 10, 2024 at 3:16 PM David Handermann < > > > > > >> > > exceptionfact...@apache.org> wrote: > > > > > >> > > > > > > > >> > > > Ferenc, > > > > > >> > > > > > > > > >> > > > Thanks for summarizing the status of key issues. > > > > > >> > > > > > > > > >> > > > With the dependency upgrades addressed and the other > noted pull > > > > > >> > > > requests merged, the support branch seems to be in a good > > > > position > > > > > >> for > > > > > >> > > > a release candidate build. > > > > > >> > > > > > > > > >> > > > Regards, > > > > > >> > > > David Handermann > > > > > >> > > > > > > > > >> > > > On Fri, Oct 4, 2024 at 6:52 AM Ferenc Kis < > > > > > briansolo1...@gmail.com> > > > > > >> > wrote: > > > > > >> > > > > > > > > > >> > > > > Hi Team, > > > > > >> > > > > > > > > > >> > > > > let's recap on the current status. > > > > > >> > > > > > > > > > >> > > > > * These tickets are still in progress, but seem to get > close > > > > to > > > > > >> merge > > > > > >> > > > > https://issues.apache.org/jira/browse/NIFI-13744 - > > > > > >> > > > > https://github.com/apache/nifi/pull/9285 > > > > > >> > > > > https://issues.apache.org/jira/browse/NIFI-13776 - > > > > > >> > > > > https://github.com/apache/nifi/pull/9286 > > > > > >> > > > > > > > > > >> > > > > * As discussed I went through the dependencies, and > updated as > > > > > >> much > > > > > >> > as I > > > > > >> > > > > could. > > > > > >> > > > > Details are on the Jira, but in a nutshell: went > through the > > > > > >> commits > > > > > >> > from > > > > > >> > > > > the 2024 year which contain dependency upgrades. These > commits > > > > > are > > > > > >> > from > > > > > >> > > > the > > > > > >> > > > > 1.26 and the 1.27 release period, so the list should > reflect > > > > > well > > > > > >> > which > > > > > >> > > > > dependencies are usually upgraded from release to > release. > > > > > >> > > > > Unfortunately not all dependency upgrades were feasible > due to > > > > > >> > various > > > > > >> > > > > reasons. If I remember correctly this was the reason > why those > > > > > >> > components > > > > > >> > > > > were deprecated and removed from the NiFi 2.x line. > > > > > >> > > > > *This PR needs to be reviewed.* > > > > > >> > > > > https://issues.apache.org/jira/browse/NIFI-13836 - > > > > > >> > > > > https://github.com/apache/nifi/pull/9340 > > > > > >> > > > > > > > > > >> > > > > * As requested I created a Jira for backporting > NIFI-13529. > > > > The > > > > > >> > commit > > > > > >> > > > > couldn't be simply cherry-picked to support/1.x due to > major > > > > > >> > refactorings > > > > > >> > > > > on the 2.x line. > > > > > >> > > > > *This PR needs to be reviewed.* > > > > > >> > > > > https://issues.apache.org/jira/browse/NIFI-13837 - > > > > > >> > > > > https://github.com/apache/nifi/pull/9341 > > > > > >> > > > > > > > > > >> > > > > Regards > > > > > >> > > > > Ferenc > > > > > >> > > > > > > > > > >> > > > > On Thu, Oct 3, 2024 at 10:31 AM Mathew Kiprop < > > > > > >> > mathewkipro...@gmail.com> > > > > > >> > > > > wrote: > > > > > >> > > > > > > > > > >> > > > > > Hi team, > > > > > >> > > > > > > > > > > >> > > > > > Is this issue[1] backported to the 1.x line and will > it be > > > > > >> > available in > > > > > >> > > > > > 1.28.0? I haven't seen it tracked here [2] > > > > > >> > > > > > > > > > > >> > > > > > [1] https://github.com/apache/nifi/pull/9066 > > > > > >> > > > > > [2] > > > > > >> https://issues.apache.org/jira/projects/NIFI/versions/12354883 > > > > > >> > > > > > > > > > > >> > > > > > On Mon, Sep 30, 2024 at 9:33 PM David Handermann < > > > > > >> > > > > > exceptionfact...@apache.org> wrote: > > > > > >> > > > > > > > > > > >> > > > > > > Ferenc, > > > > > >> > > > > > > > > > > > >> > > > > > > Thanks for reviewing the dependency upgrades. > > > > > >> > > > > > > > > > > > >> > > > > > > Reviewing the issues assigned to release version > 1.28.0 > > > > [1] > > > > > >> > there are > > > > > >> > > > > > > several new Processors, and additional features, so > that > > > > > seems > > > > > >> > the > > > > > >> > > > > > > logical next step for a new version. > > > > > >> > > > > > > > > > > > >> > > > > > > We are also approaching readiness for the 2.0.0 > release, > > > > > but I > > > > > >> > will > > > > > >> > > > > > > start a separate thread on that when ready. > > > > > >> > > > > > > > > > > > >> > > > > > > Regards, > > > > > >> > > > > > > David Handermann > > > > > >> > > > > > > > > > > > >> > > > > > > [1] > > > > > >> > > https://issues.apache.org/jira/projects/NIFI/versions/12354883 > > > > > >> > > > > > > > > > > > >> > > > > > > On Mon, Sep 30, 2024 at 6:26 AM Ferenc Kis < > > > > > >> > briansolo1...@gmail.com> > > > > > >> > > > > > > wrote: > > > > > >> > > > > > > > > > > > > >> > > > > > > > Hi Joe, > > > > > >> > > > > > > > > > > > > >> > > > > > > > Thanks for the heads up. I agree with the > importance of > > > > > >> > dependency > > > > > >> > > > > > > upgrades. > > > > > >> > > > > > > > > > > > > >> > > > > > > > I will go through the list of dependencies, and > update > > > > > >> > whichever is > > > > > >> > > > > > > > feasible, particularly the ones with critical or > high > > > > CVE > > > > > >> > ranks. > > > > > >> > > > > > > > This will also give some time buffer for the > community > > > > to > > > > > >> > finish > > > > > >> > > > the > > > > > >> > > > > > > > Jiras/PRs in progress. > > > > > >> > > > > > > > > > > > > >> > > > > > > > Also if the community thinks that the current > feature > > > > set > > > > > / > > > > > >> > > > dependency > > > > > >> > > > > > > > upgrades are not enough for a full-fledged > release, we > > > > can > > > > > >> go > > > > > >> > with > > > > > >> > > > > > > 1.27.1. > > > > > >> > > > > > > > > > > > > >> > > > > > > > Looking forward to hearing your thoughts. > > > > > >> > > > > > > > > > > > > >> > > > > > > > Regards > > > > > >> > > > > > > > Ferenc > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > On Fri, Sep 27, 2024 at 8:37 PM Mike Thomsen < > > > > > >> > > > mikerthom...@gmail.com> > > > > > >> > > > > > > wrote: > > > > > >> > > > > > > > > > > > > >> > > > > > > > > I just pushed a bunch of updates to 13776. > Apologies > > > > for > > > > > >> the > > > > > >> > > > delay. > > > > > >> > > > > > > Been > > > > > >> > > > > > > > > dealing with a lot of stuff this week that kept > > > > pulling > > > > > me > > > > > >> > away. > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > On Fri, Sep 27, 2024 at 10:13 AM Ferenc Kis < > > > > > >> > > > briansolo1...@gmail.com > > > > > >> > > > > > > > > > > > >> > > > > > > > > wrote: > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > Hi Team, > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > Let's recap on the status. > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > I'm aware of four tickets we are waiting for > to get > > > > > into > > > > > >> > the > > > > > >> > > > NiFi > > > > > >> > > > > > > 1.28 > > > > > >> > > > > > > > > > release. > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > - > > > > https://issues.apache.org/jira/browse/NIFI-13776 > > > > > : > > > > > >> > this is > > > > > >> > > > > > > currently > > > > > >> > > > > > > > > > being reviewed on the 2.x line. My guess > is once > > > > > it's > > > > > >> > been > > > > > >> > > > > > merged > > > > > >> > > > > > > into > > > > > >> > > > > > > > > > main, we can merge the PR for the 1.x line > as > > > > well > > > > > >> > > > > > > > > > - > > > > https://issues.apache.org/jira/browse/NIFI-13776 > > > > > : > > > > > >> > this > > > > > >> > > > is a > > > > > >> > > > > > 1.x > > > > > >> > > > > > > > > only > > > > > >> > > > > > > > > > bugfix, and being reviewed > > > > > >> > > > > > > > > > - > > > > https://issues.apache.org/jira/browse/NIFI-13765 > > > > > : > > > > > >> > Jira is > > > > > >> > > > > > > closed, > > > > > >> > > > > > > > > it > > > > > >> > > > > > > > > > turned out the issue does not impact the > 1.x line > > > > > >> > > > > > > > > > - > > > > https://issues.apache.org/jira/browse/NIFI-13782 > > > > > : > > > > > >> it > > > > > >> > > > seems > > > > > >> > > > > > it's > > > > > >> > > > > > > > > more > > > > > >> > > > > > > > > > complex than expected and needs additional > > > > efforts > > > > > to > > > > > >> > > > complete > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > In summary I think we should wait for the > first two > > > > > >> > tickets as > > > > > >> > > > > > those > > > > > >> > > > > > > are > > > > > >> > > > > > > > > > near to completion, then kick off the release. > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > What do you think? Is there anything else we > should > > > > > add > > > > > >> to > > > > > >> > the > > > > > >> > > > > > > release? > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > Regards > > > > > >> > > > > > > > > > Ferenc Kis > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > On Thu, Sep 19, 2024 at 4:51 PM Shane Ardell < > > > > > >> > > > > > > shane.m.ard...@gmail.com> > > > > > >> > > > > > > > > > wrote: > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > I'm also working on > > > > > >> > > > > > > https://issues.apache.org/jira/browse/NIFI-13765. > > > > > >> > > > > > > > > > > Although not critical, it would be nice to > have > > > > this > > > > > >> in > > > > > >> > the > > > > > >> > > > next > > > > > >> > > > > > > > > release. > > > > > >> > > > > > > > > > > The fix is simple and I should have a PR > open by > > > > > >> > tomorrow. > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > Best, > > > > > >> > > > > > > > > > > Shane > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > On Thu, Sep 19, 2024 at 7:23 AM Ferenc Kis < > > > > > >> > > > > > > briansolo1...@gmail.com> > > > > > >> > > > > > > > > > > wrote: > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > Thank you for your feedback > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > I think it is worth to wait for both > fixes as > > > > > those > > > > > >> > seem > > > > > >> > > > to fix > > > > > >> > > > > > > > > > critical > > > > > >> > > > > > > > > > > > issues > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > Let's reiterate on this next week > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > Regards > > > > > >> > > > > > > > > > > > Ferenc Kis > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > On Thu, Sep 19, 2024 at 12:40 AM Dan S < > > > > > >> > dsti...@gmail.com> > > > > > >> > > > > > > wrote: > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > I am also working on NIFI-13744 > > > > > >> > > > > > > > > > > > > < > > > > > https://issues.apache.org/jira/browse/NIFI-13744 > > > > > >> > > > > > > >> > > > which is > > > > > >> > > > > > a > > > > > >> > > > > > > bug > > > > > >> > > > > > > > > in > > > > > >> > > > > > > > > > > how > > > > > >> > > > > > > > > > > > > ExcelReader handles dates, times and > > > > timestamps. > > > > > >> I am > > > > > >> > > > also > > > > > >> > > > > > > > > targeting > > > > > >> > > > > > > > > > > for > > > > > >> > > > > > > > > > > > a > > > > > >> > > > > > > > > > > > > fix by the end of the week. > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > On Wed, Sep 18, 2024 at 4:31 PM Mike > Thomsen < > > > > > >> > > > > > > > > mikerthom...@gmail.com > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > wrote: > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > I found a serious bug in how > copys3object > > > > > >> handles > > > > > >> > large > > > > > >> > > > > > > files and > > > > > >> > > > > > > > > > am > > > > > >> > > > > > > > > > > > > > working on a fix. I should have it > ready by > > > > > the > > > > > >> > end of > > > > > >> > > > the > > > > > >> > > > > > > week, > > > > > >> > > > > > > > > > but > > > > > >> > > > > > > > > > > > > > without it the processor is broken on > large > > > > > file > > > > > >> > copy > > > > > >> > > > > > > actions. > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > Sent from my iPhone > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > On Sep 18, 2024, at 10:41 AM, Lucas > > > > > >> Ottersbach < > > > > > >> > > > > > > > > > > > > > lucas.ottersb...@gmail.com> wrote: > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > Hey Ferenc, > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > thank you for starting the > discussion. It > > > > > >> sounds > > > > > >> > > > like a > > > > > >> > > > > > > > > > reasonable > > > > > >> > > > > > > > > > > > > amount > > > > > >> > > > > > > > > > > > > > > of time has passed and changes were > > > > > introduced > > > > > >> > since > > > > > >> > > > the > > > > > >> > > > > > > last > > > > > >> > > > > > > > > > > > release. > > > > > >> > > > > > > > > > > > > > > Waiting for the one pending PR sound > > > > > >> reasonable. > > > > > >> > > > > > > > > > > > > > > Definitely a +1 from my side. > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > Best regards, > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > Lucas > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > Ferenc Kis <briansolo1...@gmail.com > > > > > > > schrieb > > > > > >> am > > > > > >> > > > Mi., 18. > > > > > >> > > > > > > Sept. > > > > > >> > > > > > > > > > > 2024, > > > > > >> > > > > > > > > > > > > > 12:33: > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Hi Team, > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> I'd like to initiate a discussion > about > > > > the > > > > > >> next > > > > > >> > > > release > > > > > >> > > > > > > of > > > > > >> > > > > > > > > NiFi > > > > > >> > > > > > > > > > > > 1.x. > > > > > >> > > > > > > > > > > > > > >> Since the release of Apache NiFi > 1.27, > > > > > >> several > > > > > >> > > > important > > > > > >> > > > > > > bugs > > > > > >> > > > > > > > > > [1] > > > > > >> > > > > > > > > > > > > > including > > > > > >> > > > > > > > > > > > > > >> NIFI-13675 [2] have been resolved, > and > > > > > there > > > > > >> > have > > > > > >> > > > been a > > > > > >> > > > > > > > > handful > > > > > >> > > > > > > > > > > of > > > > > >> > > > > > > > > > > > > > >> features, improvements and > dependency > > > > > updates > > > > > >> > [3] > > > > > >> > > > added > > > > > >> > > > > > > to the > > > > > >> > > > > > > > > > > > > nifi-1.x > > > > > >> > > > > > > > > > > > > > >> branch. > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> Currently there is only one ticket > > > > waiting > > > > > >> for > > > > > >> > > > review, > > > > > >> > > > > > > all the > > > > > >> > > > > > > > > > > > others > > > > > >> > > > > > > > > > > > > > are > > > > > >> > > > > > > > > > > > > > >> merged, > > > > > >> > > > > > > > > > > > > > >> so it seems we are in a good > position to > > > > > kick > > > > > >> > off a > > > > > >> > > > > > > release > > > > > >> > > > > > > > > for > > > > > >> > > > > > > > > > > NiFi > > > > > >> > > > > > > > > > > > > > 1.28.0 > > > > > >> > > > > > > > > > > > > > >> [4]. > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> I would be glad to handle the > Release > > > > > Manager > > > > > >> > > > > > > responsibilities > > > > > >> > > > > > > > > > for > > > > > >> > > > > > > > > > > > the > > > > > >> > > > > > > > > > > > > > >> 1.28.0 > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> Do you agree it is time for a new > release > > > > > or > > > > > >> do > > > > > >> > you > > > > > >> > > > see > > > > > >> > > > > > > > > > additional > > > > > >> > > > > > > > > > > > > > changes > > > > > >> > > > > > > > > > > > > > >> we should make? > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> Regards, > > > > > >> > > > > > > > > > > > > > >> Ferenc Kis > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> [1] > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > >> > > > > > > >> > > > > > > > > > > https://issues.apache.org/jira/browse/NIFI-13742?jql=project%20%3D%20NIFI%20AND%20issuetype%20%3D%20Bug%20AND%20fixVersion%20%3D%201.28.0 > > > > > >> > > > > > > > > > > > > > >> [2] > > > > > >> > > > https://issues.apache.org/jira/browse/NIFI-13675 > > > > > >> > > > > > > > > > > > > > >> [3] > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > >> > > > > > > >> > > > > > > > > > > https://issues.apache.org/jira/browse/NIFI-13727?jql=project%20%3D%20NIFI%20AND%20fixVersion%20%3D%201.28.0%20AND%20type%20!%3D%20BUG > > > > > >> > > > > > > > > > > > > > >> [4] > > > > > >> > > > > > > > > > > > > > > > >> > > > > https://issues.apache.org/jira/projects/NIFI/versions/12354883 > > > > > >> > > > > > > > > > > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > >