Ifropc commented on pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-629735553
Hi @skhdl , thanks you for your feedback. 1. Done 2. I think in general it's not very good approach, as it is not following XDG base directory specification. I understand that currently NLP craft do store some files there, so I think this should remain open for discussion and for now I leave it as is. In future, we may consider either moving NLP craft files to XDG supported directory, or make it configurable in some other way (environment variable, configuration in file, etc). 3. It's already done after successful installation. Are you talking about `/tmp/fastText/` 4. Yes, it's checked in installation script. 5. Done 6. Done. Please use **/synonyms** endpoint. 7. This part is a bit tricky. I am going to improve performance, but it might take some time to make proper batching into models, so it might be out of scope of current pull request and left as improvement for next iteration. 8. Yes, it was already implemented, but I forgot to add it as part of API. Please pass this value as **"limit"** 9. Done Also I upgraded torch to latest version (1.5), please re-run install script. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
