skhdl commented on pull request #1:
URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-629613105
Hi @Ifropc ! Thank your for your work, I have tried it and results are very
impressive!
Below some remarks for discussion:
1. start_server.sh - I think that better to use python3 instead of python.
2. Is it possible to download data to user home folder (and use it from
there)? For example under ~/<user-home>/nlpcraft/<bert?>
3. How can we clear installation files? Maybe we can add some flag like
-reset to install_dependencies.sh or create new script like
clear_dependencies.sh?
4. Should I have python3 already installed?
- If yes - could you describe it in readme? (versions etc)
- If no - we have to create ticket to check it on clear computer without
any python related installations.
5. I think we can drop `#` usage at least from API (indexes parameters are
enough and more flexible). Support of both modes confused.
6. I think we have to separate endpoints URLs (now we have only default
one), because later we can need some additional endpoints and have to separate
them.
7. Is it possible to add some new endpoint (or change current with some
parameter) which can return suggestions for each word of sentence?
- Now we can do it sending N requests for each N sentence words, but it can
be too slow because each request takes about 0.2 secs
- Will we have some performance improvements with such new endpoint ?
8. Can I control suggestions result count? (maybe via some parameter)
Let's discuss!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
