Done, thank you! -- Aaron Radzinski
On Mon, Jun 1, 2020 at 4:56 AM Paul King <[email protected]> wrote: > Forgot to mention. Only a minor thing but you probably want to delete: > > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.5.0/ > > In general, the dist/dev area should be empty apart from when there are > pending votes in play. > > Cheers, Paul. > > > On Mon, Jun 1, 2020 at 8:52 PM Paul King <[email protected]> wrote: > > > I am +0 (I don't know whether you expect failures under Windows but I'm > > happy to change to +1 if that is expected or if you believe it is > something > > in my environment). > > > > I checked: > > > > - "incubating" in name > > - DISCLAIMER exists > > - LICENSE and NOTICE look good > > - no unexpected binary files > > - signatures okay > > - hashes okay > > - rat checks are okay (I'd suggest removing > > <numUnapprovedLicenses>1000000</numUnapprovedLicenses> and adding exclude > > for .yaml files) > > - mvn clean package verify passes on Linux under JDK11 (and doesn't > > include L/GPL files when -Prelease is given) > > - mvn verify fails under Windows JDK8 and 11 (see below) > > > > Windows Surefire Failure: > > > > [ERROR] Errors: > >> [ERROR] > >> NCEnricherNestedModelSpec.test:41->NCEnricherBaseSpec.runBatch:153 ยป > >> TestFailed > >> [ERROR] Tests run: 29, Failures: 0, Errors: 1, Skipped: 1 > >> !!! Failed 2 from 3 tests. See errors list above. !!! > >> at > >> > org.apache.nlpcraft.probe.mgrs.nlp.enrichers.model.NCEnricherNestedModelSpec.test(NCEnricherNestedModelSpec.scala:41) > > > > > > There are errors like below throughout the console logs (possibly > relevant > > or perhaps a red herring): > > > > [INFO] Caused by: java.io.IOException: Failed to deserialize object > >> [typeName=scala.collection.immutable.HashMap$SerializationProxy] > >> ... > >> [[INFO] Caused by: org.apache.ignite.IgniteCheckedException: Failed to > >> deserialize object with given class loader: > >> [clsLdr=sun.misc.Launcher$AppClassLoader@5c647e05, err=Failed to > >> deserialize object [typeName=scala.collection.mutable.HashSet]] > >> ... > >> [INFO] Caused by: java.lang.ClassNotFoundException: Optimized stream > >> class checksum mismatch (is same version of marshalled class present on > all > >> nodes?) [expected=32321, actual=26723, cls=class > >> scala.collection.immutable.Vector] > >> ... > >> [INFO] Caused by: org.apache.ignite.binary.BinaryObjectException: Failed > >> to read field > >> [name=org$apache$nlpcraft$common$nlp$NCNlpSentenceToken$$notes] > >> ... > >> [INFO] Caused by: org.apache.ignite.binary.BinaryObjectException: Failed > >> to deserialize object > >> [typeName=org.apache.nlpcraft.common.nlp.NCNlpSentenceToken] > >> ... > >> [INFO] Jun-01|20:16:32|ERROR| System error processing query: class > >> org.apache.ignite.IgniteCheckedException: Failed to deserialize object > >> > [typeName=org.apache.nlpcraft.server.nlp.enrichers.NCServerEnrichmentManager$Holder] > > > > > > Cheers, Paul. > > > > > > On Sat, May 30, 2020 at 3:49 AM Aaron Radzinski < > [email protected]> > > wrote: > > > >> NLPCraft-ers, > >> This is the vote for release of NLPCraft v0.6.0. This release includes a > >> number of bug fixes, improvements and brand new real-life example of > >> accessing SQL databases using natural language. > >> > >> NOTE: we've fixed the Windows-related issue causing a last minute delay > >> with the last 0.6.0 release attempt. > >> > >> Quick links: > >> 1. Release location: > >> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/ > >> 2. GitHub v0.6.0 tag: > >> https://github.com/apache/incubator-nlpcraft/tree/v0.6.0 > >> 3. JIRA issues closed: > >> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347775 > >> 4. KEYS file: > >> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS > >> <https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347774> > >> > >> The vote is formal, see voting guidelines here: > >> https://www.apache.org/foundation/voting.html > >> +1 - to accept Apache NLPCraft 0.6.0 > >> 0 - don't care either way > >> -1 - DO NOT accept Apache NLPCraft 0.6.0 (explain why) > >> > >> See notes on how to verify release here: > >> https://www.apache.org/info/verification.html > >> > >> The vote will be held for 72 hours and will end on June 1, 2020 at > >> midnight > >> MSK. > >> > >> Thank you! > >> -- > >> Aaron Radzinski > >> > > >
