Hi, +1 from me.
I checked: - Incubating in name - DISCLAIMER exists - LICENSE and NOTICE are fine - No unexpected binary files - Checked PGP signatures - Checked Checksums - Code compiles and tests successfully run - Apache rat checks are OK PS: I still get these errors pn Apache rat checks which may not be crucial: [ERROR] VM #displayTree: error : too few arguments to macro. Wanted 2 got 0 [ERROR] VM #menuItem: error : too few arguments to macro. Wanted 1 got 0 Kind Regards, Furkan KAMACI On Tue, Jul 14, 2020 at 10:30 PM Aaron Radzinski <[email protected]> wrote: > Paul, > Fixed 'numUnapprovedLicenses' in master: > > https://github.com/apache/incubator-nlpcraft/commit/5c800be2013f78a693a36a60b13358092e7e4732 > > Thanks, > -- > Aaron Radzinski > > > > On Mon, Jul 13, 2020 at 9:49 PM Paul King <[email protected]> wrote: > > > > +1 > > > > Checked hashes and signatures. > > "maven clean verify" passes (fails on Windows JDK8 as per NLPCRAFT-76, > > passes on Linux JDK11) > > "maven apache-rat:rat" passes (but it is configured to ignore failures, > you > > can change numUnapprovedLicenses in the pom from 1000000 to 0 and it > still > > currently passes, this looks like a good idea) > > incubating in name > > DISCLAIMER exists > > NOTICE seems okay > > LICENSE seems okay > > no unexpected binary files > > licensing issues found by Justin last time seem sorted > > > > Cheers, Paul. > > > > > > On Fri, Jul 10, 2020 at 8:43 AM Aaron Radzinski < > [email protected] > > > > wrote: > > > > > NLPCraft-ers, > > > This is a call for a vote to release Apache NLPCraft (incubating) > version > > > 0.6.2. As you may know, we've been working on refactoring the > configuration > > > for several of our subsystems due to CC BY 4.0 licensing that caused us > > > trouble last time. We've worked with Apache Legal and run our solution > by > > > Justin McLean so we are confident in our resolution. > > > > > > In short, NLPCraft 0.6.2 ships with the default configuration that is > fully > > > ASL 2.0 licensed. Users have an option to manually download a separate > > > pre-packaged configuration that includes content based on CC BY 4.0 > > > license, if they desire so and accept CC BY 4.0 license restrictions. > > > > > > Release information: > > > 1. Release location: > > > > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.6.2/ > > > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.6.2 > > > 4. JIRA issues fixed in release: > > > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347775 > > > 5. KEYS file: > > > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS > > > > > > The vote will be open for at least 72 hours or until a necessary number > of > > > votes are reached. > > > > > > Please vote accordingly: > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > Thank you, > > > -- > > > Aaron Radzinski > > > >
