[
https://issues.apache.org/jira/browse/NUTCH-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166477#comment-16166477
]
ASF GitHub Bot commented on NUTCH-2375:
---------------------------------------
sebastian-nagel commented on a change in pull request #221: NUTCH-2375
Upgrading nutch to use org.apache.hadoop.mapreduce
URL: https://github.com/apache/nutch/pull/221#discussion_r138925338
##########
File path: src/java/org/apache/nutch/indexer/IndexerMapReduce.java
##########
@@ -70,51 +68,26 @@
public static final String URL_NORMALIZING = "indexer.url.normalizers";
public static final String INDEXER_BINARY_AS_BASE64 =
"indexer.binary.base64";
- private boolean skip = false;
- private boolean delete = false;
- private boolean deleteRobotsNoIndex = false;
- private boolean deleteSkippedByIndexingFilter = false;
- private boolean base64 = false;
- private IndexingFilters filters;
- private ScoringFilters scfilters;
+ private static boolean skip = false;
+ private static boolean delete = false;
+ private static boolean deleteRobotsNoIndex = false;
+ private static boolean deleteSkippedByIndexingFilter = false;
+ private static boolean base64 = false;
+ private static IndexingFilters filters;
+ private static ScoringFilters scfilters;
// using normalizers and/or filters
- private boolean normalize = false;
- private boolean filter = false;
+ private static boolean normalize = false;
+ private static boolean filter = false;
// url normalizers, filters and job configuration
- private URLNormalizers urlNormalizers;
- private URLFilters urlFilters;
+ private static URLNormalizers urlNormalizers;
+ private static URLFilters urlFilters;
Review comment:
Regarding static variables, see comments in Generator. Afaics, they're
really shared between IndexerMapper and IndexerReducer. But then the code for
initialization is also best shared to avoid duplicate code (cf. setup methods
of mapper and reducer).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade the code base from org.apache.hadoop.mapred to
> org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: NUTCH-2375
> URL: https://issues.apache.org/jira/browse/NUTCH-2375
> Project: Nutch
> Issue Type: Improvement
> Components: deployment
> Reporter: Omkar Reddy
>
> Nutch is still using the deprecated org.apache.hadoop.mapred dependency which
> has been deprecated. It need to be updated to org.apache.hadoop.mapreduce
> dependency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
