[
https://issues.apache.org/jira/browse/NUTCH-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166476#comment-16166476
]
ASF GitHub Bot commented on NUTCH-2375:
---------------------------------------
sebastian-nagel commented on a change in pull request #221: NUTCH-2375
Upgrading nutch to use org.apache.hadoop.mapreduce
URL: https://github.com/apache/nutch/pull/221#discussion_r138926576
##########
File path: src/java/org/apache/nutch/parse/ParseOutputFormat.java
##########
@@ -48,14 +61,19 @@
import org.apache.hadoop.util.Progressable;
/* Parse content in a segment. */
-public class ParseOutputFormat implements OutputFormat<Text, Parse> {
+public class ParseOutputFormat extends OutputFormat<Text, Parse> {
private static final Logger LOG = LoggerFactory
.getLogger(MethodHandles.lookup().lookupClass());
private URLFilters filters;
private URLExemptionFilters exemptionFilters;
private URLNormalizers normalizers;
private ScoringFilters scfilters;
-
+ private static final NumberFormat NUMBER_FORMAT = NumberFormat.getInstance();
Review comment:
NumberFormat isn't thread-safe. Should definitely not be static!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade the code base from org.apache.hadoop.mapred to
> org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: NUTCH-2375
> URL: https://issues.apache.org/jira/browse/NUTCH-2375
> Project: Nutch
> Issue Type: Improvement
> Components: deployment
> Reporter: Omkar Reddy
>
> Nutch is still using the deprecated org.apache.hadoop.mapred dependency which
> has been deprecated. It need to be updated to org.apache.hadoop.mapreduce
> dependency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
