[ 
https://issues.apache.org/jira/browse/NUTCH-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166484#comment-16166484
 ] 

ASF GitHub Bot commented on NUTCH-2375:
---------------------------------------

sebastian-nagel commented on a change in pull request #221: NUTCH-2375 
Upgrading nutch to use org.apache.hadoop.mapreduce
URL: https://github.com/apache/nutch/pull/221#discussion_r138930916
 
 

 ##########
 File path: src/java/org/apache/nutch/tools/FreeGenerator.java
 ##########
 @@ -66,79 +64,80 @@
   private static final String FILTER_KEY = "free.generator.filter";
   private static final String NORMALIZE_KEY = "free.generator.normalize";
 
-  public static class FG extends MapReduceBase implements
-      Mapper<WritableComparable<?>, Text, Text, Generator.SelectorEntry>,
-      Reducer<Text, Generator.SelectorEntry, Text, CrawlDatum> {
-    private URLNormalizers normalizers = null;
-    private URLFilters filters = null;
-    private ScoringFilters scfilters;
-    private CrawlDatum datum = new CrawlDatum();
-    private Text url = new Text();
-    private int defaultInterval = 0;
+  public static class FG {
+    private static URLNormalizers normalizers = null;
+    private static URLFilters filters = null;
+    private static ScoringFilters scfilters;
+    private static CrawlDatum datum = new CrawlDatum();
+    private static Text url = new Text();
+    private static int defaultInterval = 0;
 
 Review comment:
   See comments in Generator etc. regarding static variables shared between 
mapper and reducer classes.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Upgrade the code base from org.apache.hadoop.mapred to 
> org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
>                 Key: NUTCH-2375
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2375
>             Project: Nutch
>          Issue Type: Improvement
>          Components: deployment
>            Reporter: Omkar Reddy
>
> Nutch is still using the deprecated org.apache.hadoop.mapred dependency which 
> has been deprecated. It need to be updated to org.apache.hadoop.mapreduce 
> dependency. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to