[ 
https://issues.apache.org/jira/browse/NUTCH-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166487#comment-16166487
 ] 

ASF GitHub Bot commented on NUTCH-2375:
---------------------------------------

sebastian-nagel commented on a change in pull request #221: NUTCH-2375 
Upgrading nutch to use org.apache.hadoop.mapreduce
URL: https://github.com/apache/nutch/pull/221#discussion_r138927288
 
 

 ##########
 File path: src/java/org/apache/nutch/parse/ParseSegment.java
 ##########
 @@ -43,20 +50,16 @@
 import java.util.Map.Entry;
 
 /* Parse content in a segment. */
-public class ParseSegment extends NutchTool implements Tool,
-    Mapper<WritableComparable<?>, Content, Text, ParseImpl>,
-    Reducer<Text, Writable, Text, Writable> {
+public class ParseSegment extends NutchTool implements Tool {
 
   private static final Logger LOG = LoggerFactory
       .getLogger(MethodHandles.lookup().lookupClass());
 
   public static final String SKIP_TRUNCATED = "parser.skip.truncated";
 
-  private ScoringFilters scfilters;
+  private static ScoringFilters scfilters;
 
-  private ParseUtil parseUtil;
-
-  private boolean skipTruncated;
+  private static  boolean skipTruncated;
 
 Review comment:
   See comments in Generator etc. regarding static variables shared between 
mapper and reducer classes.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Upgrade the code base from org.apache.hadoop.mapred to 
> org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
>                 Key: NUTCH-2375
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2375
>             Project: Nutch
>          Issue Type: Improvement
>          Components: deployment
>            Reporter: Omkar Reddy
>
> Nutch is still using the deprecated org.apache.hadoop.mapred dependency which 
> has been deprecated. It need to be updated to org.apache.hadoop.mapreduce 
> dependency. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to