[ 
https://issues.apache.org/jira/browse/NUTCH-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343314#comment-16343314
 ] 

ASF GitHub Bot commented on NUTCH-2505:
---------------------------------------

sebastian-nagel commented on a change in pull request #282: fix for NUTCH-2505 
contributed by lianyuzhe
URL: https://github.com/apache/nutch/pull/282#discussion_r164418338
 
 

 ##########
 File path: src/java/org/apache/nutch/crawl/Generator.java
 ##########
 @@ -752,6 +752,7 @@ public Generator(Configuration conf) {
       }
     } catch (Exception e) {
       LOG.warn("Generator: exception while partitioning segments, exiting 
...");
+      LockUtil.removeLockFile(getConf(),lock);
 
 Review comment:
   Thanks @lianyuzhe, good catch!
   +1 to remove the lock of the CrawlDb. There may be good or broken segments 
left from the partition jobs run in the loop. Would be nice to clean them up as 
well. But that's clearly a different task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> nutch does not delete the .locked file, when the generator partition got an 
> exception
> -------------------------------------------------------------------------------------
>
>                 Key: NUTCH-2505
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2505
>             Project: Nutch
>          Issue Type: Bug
>          Components: generator
>            Reporter: Ajoy Lian
>            Priority: Major
>
> nutch does not delete the .locked file when the generator partition got an 
> exception. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to