[
https://issues.apache.org/jira/browse/NUTCH-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351882#comment-16351882
]
ASF GitHub Bot commented on NUTCH-2505:
---------------------------------------
sebastian-nagel commented on a change in pull request #282: fix for NUTCH-2505
contributed by lianyuzhe
URL: https://github.com/apache/nutch/pull/282#discussion_r165856413
##########
File path: src/java/org/apache/nutch/crawl/Generator.java
##########
@@ -752,6 +752,7 @@ public Generator(Configuration conf) {
}
} catch (Exception e) {
LOG.warn("Generator: exception while partitioning segments, exiting
...");
+ LockUtil.removeLockFile(getConf(),lock);
Review comment:
Yes, of course, if it's possible to properly catch the exception and safely
delete the generated segment(s). It's your decision whether to extend the PR or
to open a new issue. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> nutch does not delete the .locked file, when the generator partition got an
> exception
> -------------------------------------------------------------------------------------
>
> Key: NUTCH-2505
> URL: https://issues.apache.org/jira/browse/NUTCH-2505
> Project: Nutch
> Issue Type: Bug
> Components: generator
> Reporter: Ajoy Lian
> Priority: Major
>
> nutch does not delete the .locked file when the generator partition got an
> exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
